Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cache for plex images #20

Open
gugahoi opened this issue Mar 21, 2014 · 5 comments
Open

Add cache for plex images #20

gugahoi opened this issue Mar 21, 2014 · 5 comments
Assignees
Labels

Comments

@gugahoi
Copy link
Owner

gugahoi commented Mar 21, 2014

No description provided.

@gugahoi gugahoi added this to the Expanded Plex Integration milestone Mar 21, 2014
@gugahoi gugahoi self-assigned this Mar 21, 2014
@gugahoi gugahoi added the todo label Mar 21, 2014
@Wraithers
Copy link

Also, add blank thumbnails for media that doesn't have a thumbnail generated in Plex.

Just in case it helps, following is how each show up. Though it would probably be better to target it via class assigning if it has or a thumb or not.

  • With thumbnail:

    <img src="http://192.168.1.160:32400/library/metadata/56/thumb/1388595068" class="movie">

  • Without thumbnail:

    <img src="http://192.168.1.160:32400" class="movie">

@Wraithers
Copy link

Hey, I'd like to suggest the attached image to replace the poster.png for media without thumbnails, for consistency with Plex =)

Cropped & resized to match the file you used:
poster

(Sorry this is partially off-topic)

@gugahoi
Copy link
Owner Author

gugahoi commented Mar 22, 2014

The thumb I used is already in Maraschino so more likely to be in cache. I dont know how it's looking in the module tho since I cant remove a thumb from my media and the random one that I populated in my library wont show up on my On Deck collection. Does it look bad?

future reference: plex has a blob REST service, might be better that using local cache:
blob:http%3A//plex.tv/594fe83f-33c5-45f9-a450-867efac651ac

@Wraithers
Copy link

Yup, it doesn't sit well with the rest of the Plex module, if already using similar icons and all, would be best to switch the poster over as well.

@gugahoi
Copy link
Owner Author

gugahoi commented Apr 3, 2014

I have just added a proxy url in maraschino for plex images so now as long as maraschino can access the server it will be able to retrieve images anywhere in the world.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants