Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implemented a Delete functionality for KeyValue #2033

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Implemented a Delete functionality for KeyValue #2033

wants to merge 8 commits into from

Conversation

nathannaveen
Copy link
Contributor

Description of the PR

PR Checklist

  • All commits have a Developer Certificate of Origin (DCO) -- they are generated using -s flag to git commit.
  • All new changes are covered by tests
  • If GraphQL schema is changed, make generate has been run
  • If GraphQL schema is changed, GraphQL client updates/additions have been made
  • If OpenAPI spec is changed, make generate has been run
  • If ent schema is changed, make generate has been run
  • If collectsub protobuf has been changed, make proto has been run
  • All CI checks are passing (tests and formatting)
  • All dependent PRs have already been merged

@nathannaveen
Include delete functionality for KeyValue
fe6e0f2 
Signed-off-by: nathannaveen <[email protected]>
@nathannaveen
Delete Certify Vuln
b70d688 
Signed-off-by: nathannaveen <[email protected]>
@nathannaveen
Delete hasSLSA
d49ed12 
Signed-off-by: nathannaveen <[email protected]>
@nathannaveen
Delete hasSBOM
f0176af 
Signed-off-by: nathannaveen <[email protected]>
@nathannaveen nathannaveen force-pushed the nathan/implementDeleteForKeyValue branch from 586fda0 to f0176af Compare July 17, 2024 15:56
@nathannaveen
Enabled tests
c8b6ae5 
Signed-off-by: nathannaveen <[email protected]>
@nathannaveen nathannaveen force-pushed the nathan/implementDeleteForKeyValue branch from 5beeb63 to c8b6ae5 Compare July 17, 2024 16:13
@nathannaveen
Fix tests
a9d15ef 
Signed-off-by: nathannaveen <[email protected]>
@pxp928 pxp928 requested a review from jeffmendoza July 19, 2024 16:08
@nathannaveen nathannaveen requested a review from pxp928 July 19, 2024 20:20
jeffmendoza
jeffmendoza requested changes Aug 2, 2024
View reviewed changes
pkg/assembler/backends/keyvalue/path.go Outdated Show resolved Hide resolved
pkg/assembler/backends/keyvalue/certifyVuln.go Outdated Show resolved Hide resolved
@nathannaveen nathannaveen force-pushed the nathan/implementDeleteForKeyValue branch from dcb6fa1 to c5f0927 Compare August 12, 2024 19:57
@nathannaveen
Updated based on code review
2980fe7 
Signed-off-by: nathannaveen <[email protected]>
@nathannaveen nathannaveen force-pushed the nathan/implementDeleteForKeyValue branch from c5f0927 to 2980fe7 Compare August 12, 2024 19:58
@nathannaveen
Copy link
Contributor Author

After some thought, I realize that the code is going to require a lot of changes. So I am going to be converting this to a draft PR.

This is mainly because of a deep dive into the comment #2033 (comment) by @jeffmendoza.

@nathannaveen nathannaveen marked this pull request as draft August 12, 2024 20:47
@nathannaveen nathannaveen marked this pull request as ready for review August 13, 2024 18:11
@nathannaveen
Correctly removing from list
6c01d0c 
Signed-off-by: nathannaveen <[email protected]>
@nathannaveen nathannaveen force-pushed the nathan/implementDeleteForKeyValue branch from 8708cb0 to 6c01d0c Compare August 13, 2024 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mihaimaruseac mihaimaruseac Awaiting requested review from mihaimaruseac mihaimaruseac is a code owner

@pxp928 pxp928 Awaiting requested review from pxp928

@jeffmendoza jeffmendoza Awaiting requested review from jeffmendoza

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[feature] KeyValue add delete node functionality
3 participants
@nathannaveen @jeffmendoza @pxp928