Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some way to dump or insert animation C code #35

Open
grunt-lucas opened this issue Apr 6, 2024 · 3 comments
Open

Add some way to dump or insert animation C code #35

grunt-lucas opened this issue Apr 6, 2024 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@grunt-lucas
Copy link
Owner

grunt-lucas commented Apr 6, 2024

  • generate a single .h file which is expected to be #include'd in tileset_anims.c
  • users would still need to manually add the callback to src/data/tilesets/headers.h?
  • each source anim folder could have an anim.cfg file that allows users to customize the frame animation times, etc
@grunt-lucas grunt-lucas added the enhancement New feature or request label Apr 6, 2024
@grunt-lucas grunt-lucas self-assigned this Apr 6, 2024
@mrgriffin
Copy link
Collaborator

is it possible to generate the code and insert it automatically? This would be even better. Would need some kind of syntax tree parsing

A halfway house would be to generate a single .h file which is expected to be #included in tileset_anims.c. That way the user only has to insert that #include once when adding porymap to their repo, and it'll "automatically" track any porytiles rebuilds.

@grunt-lucas
Copy link
Owner Author

grunt-lucas commented Apr 6, 2024

@mrgriffin Hah! I just went on an issue-creation spree (I moved my Todo.md items over to GitHub issues). Sorry if that spammed your email! Also, your idea above is very clever. That would be the way to go, I think. Would avoid thorny C-parsing issues.

@mrgriffin
Copy link
Collaborator

Sorry if that spammed your email!

np! I like keeping up to date with what's going on in porytiles :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants