Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update minimum supported crystal version to 1.8.0 #65

Closed
yanecc opened this issue May 7, 2024 · 3 comments
Closed

Update minimum supported crystal version to 1.8.0 #65

yanecc opened this issue May 7, 2024 · 3 comments

Comments

@yanecc
Copy link
Contributor

yanecc commented May 7, 2024

Process.on_interrupt was introduced into Crystal API since 1.8.0.
@grkek
Copy link
Member

grkek commented May 11, 2024

Process.on_interrupt was introduced into Crystal API since 1.8.0.

I will implement a way to handle versions using macros to support every version of crystal since 0.36.0

@yanecc
Copy link
Contributor Author

yanecc commented May 11, 2024

Process.on_interrupt was introduced into Crystal API since 1.8.0.

I will implement a way to handle versions using macros to support every version of crystal since 0.36.0

The method Process.on_interrupt became deprecated since 1.12.0, please consider using Process.on_terminate for later version as well.

@grkek
Copy link
Member

grkek commented May 11, 2024

#67 should be a fix for this issue

@grkek grkek closed this as completed May 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@grkek @yanecc