Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GrblHAL Hangs if EEPROM is not present - iMXRT1062 #2

Open
mlewus opened this issue Jun 15, 2021 · 3 comments
Open

GrblHAL Hangs if EEPROM is not present - iMXRT1062 #2

mlewus opened this issue Jun 15, 2021 · 3 comments

Comments

@mlewus
Copy link

mlewus commented Jun 15, 2021

If the code is built for EEPROM and you boot without the EEPROM attached, the program does not respond to the USB serial port and appears to be hung.

This was an issue because the EEPROM is located on the breakout board but it is more convenient for me to build and load code with the Teensy out of its socket. I spent an hour debugging before I realized my error. Dumb, I know, but an error code would have been helpful. The same thing will presumably happen if the EEPROM becomes defective so it would be more generally useful than just my corner case.

I would suggest a code or message that resolves to something like "EEPROM not found" so it is clear that the build and load were successful even though the EEPROM is missing. If you will assign a new numeric code I'll make a pull request and make the required changes.

@terjeio
Copy link
Contributor

terjeio commented Jun 15, 2021

Use alarm 16 Alarm_SelftestFailed, see the MSP432 i2.c code for how to raise it and report the reason. That code justs checks for a stuck bus, you have add a check for the I2C EEPROM present as well.

@mlewus
Copy link
Author

mlewus commented Jun 15, 2021

That helps a lot, thanks. I also intend to implement the ability to set spindle speed as a RPM value. That is mostly a port of the work that you did in driver.C for MSP432P401R and was discussed in terjeio/grblHAL#298

Housekeeping: do you prefer that I create a fork to my own repository or do you wish to create a new branch in the project repository? Either way I will issue a pull request when I’m ready.

@terjeio
Copy link
Contributor

terjeio commented Jun 15, 2021

Create a fork to your own repo and a PR from that.

terjeio added a commit that referenced this issue Sep 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants