Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate from urql to graphql-yoga #960

Open
saihaj opened this issue Jul 16, 2024 · 0 comments
Open

Migrate from urql to graphql-yoga #960

saihaj opened this issue Jul 16, 2024 · 0 comments

Comments

@saihaj
Copy link
Member

saihaj commented Jul 16, 2024

In the refactor I started to clean things up one of the things we are doing is getting rid of URQL client. Today we have a non-traditional usage of URQL client when we are utilizing it for the API layer to serve. We export a client instance and share it in both indexer-agent and indexer-cli. There is no real GraphQL validation happening today and I found inconsistencies in the API which are not being caught.

The goal with this task is to refactor to use graphql-yoga and then tests utilities will be updated to use @graphql-tools/executor-http (see yoga docs here on testing)


I am hoping that cleaning up the URQL setup cause GraphQL client we fix our memory issues cause one of the known issues on URQL which feels like what we are seeing in #41 cause we are using the version of URQL which is suspected to have leaks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🗃️ Inbox
Development

No branches or pull requests

1 participant