Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: min_signal=0 fails pgo #50

Open
hopeyen opened this issue Feb 15, 2024 · 0 comments
Open

bug: min_signal=0 fails pgo #50

hopeyen opened this issue Feb 15, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@hopeyen
Copy link
Collaborator

hopeyen commented Feb 15, 2024

The default for signal is usually 100, which filters out subgraphs with zero signals. When an indexer wants to pinned subgraphs with 0 signals, they would lower the min_signal requirement and ran into errors pasted in the gist .
The most straight-forward solution may be excluding those subgraphs from participating in the optimization problem. Alternatively, (my intuition for modifying the algo) we would need to add additional handling for finding the zeros in the dual problem.

@hopeyen hopeyen added the bug Something isn't working label Feb 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant