Spock tests are executing @BeforeEach but not @AfterEach

[longwa]

Some of the extensions provided in this library are causing specs to execute methods annotated with JUnit5's @BeforeEach but not @AfterEach.

I'm not sure if this library is trying to emulate the @BeforeEach or if it's just something leftover, but the current behavior is not super useful.

Critically, the ordering of the calls is different than in Grails 4.0, i.e it used to be:

beforeEach
setup
test method
cleanup
afterEach

Now the ordering is:

setup
beforeEach
test method
cleanup

This makes it difficult to use @BeforeEach in a trait or base class as usually you will want that to be called first (which it used to be). Also, Spock makes it difficult since traits can't use setup() if the test class also has a setup method.

IMO, this library should implement an extension that creates compatibility with Before* and After* annotations while keeping the test order consistent with pre-5.0 behavior (and what would be considered the sensical ordering)

package test

import org.junit.jupiter.api.AfterEach
import org.junit.jupiter.api.BeforeEach
import spock.lang.Specification

class TestAnnotationSpec extends Specification {

    def "test method 1"() {
        when:
        println "test method 1"

        then:
        true
    }

    @BeforeEach
    void beforeEach() {
        println "beforeEach"
    }

    @AfterEach
    void afterEach() {
        println "afterEach"
    }

    void setup() {
        println "setup"
    }

    void cleanup() {
        println "cleanup"
    }
}

[longwa]

This was actually very easy to fix just by changing the TestingSupportExtension.

Essentially we just need to prepend the BeforeEach to the setupMethods and then add a block to handle the AfterEach. I will also add handlers for the BeforeAll and AfterAll. That should provide a nice compatibility layer between Spock and JUnit5 when using Grails 5.

I will submit a PR shortly.