Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an object factory to create SM fixtures #850

Open
3 tasks
ckbedwell opened this issue Jul 3, 2024 · 0 comments
Open
3 tasks

Add an object factory to create SM fixtures #850

ckbedwell opened this issue Jul 3, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@ckbedwell
Copy link
Contributor

Problem

At the beginning of this year I refactored the test data to be consistent across tests so there is a singular point of reference which all of our tests utilise. This is a great improvement but some tests require specific values to ensure they work correctly and often these values are unclear and opaque in nature.

Completion criteria

  • Introduce Fishery as an object factory to generate our test fixtures.
  • Where appropriate change some of our tests to utilise Fishery rather than using the global fixtures (e.g. BulkEditModal.test.tsx) -- note: it isn't a requirement to change all of our tests to utilise Fishery to consider this ticket complete but the goal is to get the ball rolling.
  • Ensure your solution allows us to utilise the object factory OUTSIDE of tests easily.

On the last point: one of the benefits of utilising Fishery is for us to mock data whilst developing locally. An example where this could be applied -- currently our call to the checks list api is not paginated and returns all checks. Some of our users have 1000s of checks and it would be a very interesting experiment to mock these 1000 of checks in the UI and see what happens and aid in developing solutions.

@ckbedwell ckbedwell added the enhancement New feature or request label Jul 3, 2024
@ckbedwell ckbedwell changed the title Add an object factory to create fixtures Add an object factory to create SM fixtures Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant