-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Failures during dependency resolution seem to be swallowed #140
Comments
It is intended that the plugin will report all resolved dependencies, and ignore any that fail to resolve. This allows us to resolve each and every dependency configuration in the project without having the graph generation fail if one of these is not fully resolvable. As far as I know, there's no mechanism to include a resolution failure in the generated GitHub dependency graph, although it would be possible to include this in some custom reporting. That would involve changing this method so that To answer your specific questions:
The
As described above, the plugin reports all resolved dependencies, and ignores ones that cannot be resolved. There's no way for the current dependency-graph to include a resolution failure, and we don't want to fail the build when one is encountered. |
That's quite unexpected, at least from my side. I've filed github/dependency-submission-toolkit#78 about it.
This seems to have been automatically introduced by a switch to Kotlin 2.0.0 in the project. |
Looks like the issue with unresolvable |
I'm not sure whether it's supposed to be like that, but what I see it that running
./gradlew dependencies
on https://github.com/wkl3nk/demo-7 givesSo there is a resolution failure in
jackson-module-kotlin
and inspecting that further with./gradlew dependencyInsight --dependency jackson-module-kotlin --configuration dependencySources
gives:However, when running this plugin's
ForceDependencyResolutionPlugin_resolveAllDependencies
on that project,dependency-graph.json
is created just fine without any issues, butjackson-module-kotlin
is simply omitted from thedependencySources
configuration.So my questions are:
ForceDependencyResolutionPlugin_resolveAllDependencies
no report it as part ofdependency-graph.json
?dependencies
task to report a failure?The text was updated successfully, but these errors were encountered: