Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: SVG icon #982

Open
DanielRamosAcosta opened this issue Sep 22, 2022 · 17 comments · May be fixed by #1550
Open

[Feature Request]: SVG icon #982

DanielRamosAcosta opened this issue Sep 22, 2022 · 17 comments · May be fixed by #1550
Assignees

Comments

@DanielRamosAcosta
Copy link

Relevant Scope

Frontend specs

Description

I've see that in the media directory are several sizes of the Real World icon, but are there any SVG?

Describe the solution you'd like

A SVG icon version

Describe alternatives you've considered

🤷🏽‍♂️

@geromegrignon
Copy link
Contributor

Hi @DanielRamosAcosta,
Sadly when the current maintenance team joined the project, the original assets were already lost.

@DanielRamosAcosta
Copy link
Author

Oh, thanks for the response @geromegrignon

@geromegrignon
Copy link
Contributor

💭 Introduction

We need a svg version of our logo.
realworld-logo

✏️ Task

  • Ask to be assigned to the issue.
  • Wait to be assigned.
  • create an SVG version of the current logo (the png version is available here
  • Submit a pull request

@fredster33
Copy link

Would this perhaps be an opportunity as well to simplify the logo, removing the shadows? I think it would show better on lower resolutions.

@Vishal2002
Copy link

Do you need to convert the current logo from PNG to SVG .

@geromegrignon
Copy link
Contributor

Hi @Vishal2002, exactly!

@Vishal2002
Copy link

Assign me this issue to work on

@geromegrignon
Copy link
Contributor

sure, done. Thanks for your help.

@Vishal2002
Copy link

Where I have to add the SVG file Can you tell me?

@geromegrignon
Copy link
Contributor

You can add it in the media folder, naming it realworld-logo.svg.

@Vishal2002
Copy link

Will this issue get counted in the hacktoberfest?

@Vishal2002
Copy link

Please add a label of hacktoberfest-accepted otherwise it won't be counted

@geromegrignon
Copy link
Contributor

sure I really appreciate the help and will apply the label on it (I don't put it on the project directly to avoid some spam).

@Vishal2002
Copy link

I am unable to see the change on the dashboard of hacktoberfest.

@geromegrignon
Copy link
Contributor

Hi @Vishal2002, the label must be applied on the Pull Request, but you didn't submit one yet to the project.

@geromegrignon
Copy link
Contributor

I looked at the file in your fork (https://github.com/Vishal2002/realworld/blob/main/media/realworld-logo%20(2).svg), and that's an inverted image, so it doesn't fit the requirement. By using it, the logo would be transparent with a black background.

@DanielRamosAcosta DanielRamosAcosta linked a pull request Jun 3, 2024 that will close this issue
@DanielRamosAcosta
Copy link
Author

DanielRamosAcosta commented Jun 15, 2024

It took me two years, but finally I did it haha, fixed in #1550 (cc @geromegrignon)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants
@DanielRamosAcosta @geromegrignon @Vishal2002 @fredster33 and others