Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The Settings page requires the email and password fields regardless of whether their changed #630

Open
rschristian opened this issue Apr 7, 2021 · 4 comments
Labels
Status: Approved approved for next version v2 changelog

Comments

@rschristian
Copy link

rschristian commented Apr 7, 2021

Currently the "Email" and "New Password" fields are required by the API when they should not be. The user is unable to update say their username without also providing their email and password. This means users are essentially overwriting both their email and password every time they go to change any field on their profile.

@rschristian rschristian changed the title The Settings page requires a password when updating any field The Settings page requires the email and password fields regardless of whether their changed Apr 8, 2021
@geromegrignon
Copy link
Contributor

geromegrignon commented Apr 15, 2021

It's pretty common to ask for authentication information when you are about to change sensitive information about the account.
It provides a way to secure those information if an user leaves thier computer unattended without locking their session.

As such changes are rare, it doesn't introduce much inconvenience for users.

There si no plan to make a related change to the API.

@rschristian
Copy link
Author

Sure, that is pretty common, however, that is not what this is.

If you provide invalid credentials on that form your changes to the account aren't rejected. Instead, the credentials for the account change entirely. There is no confirmation of credentials built into the back end for that feature.

@rschristian
Copy link
Author

If that is supposed to be a way in which the user needs to provide their credentials to change their bio, image, or username, and only those, there will probably also need to be a way to change their email and passwords.

@geromegrignon
Copy link
Contributor

I agree. We can't affect all existing implementations with such changes but the goal is to work as soon as possible on new specs based on all suggestions provided to make them more 'real'

@geromegrignon geromegrignon added v2 and removed bug labels Apr 15, 2021
@geromegrignon geromegrignon added Status: Approved approved for next version and removed v2 labels Nov 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Approved approved for next version v2 changelog
Projects
None yet
Development

No branches or pull requests

2 participants