feat: register https proxy #916
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
HTTPS proxies are not supported by the websocket package. The current code returns an error when the application specifies an HTTPS proxy. The code in this commit silently downgrades to HTTP when the application specifies an HTTPS proxy. That's dangerous from a security standpoint. Reject this PR. |
|
Agreed thanks @canelohill and appreciate the effort @jackstar12. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
This PR registers a
httpsproxy dialer type. I've tested it manually, but I'm not sure if / how to approach tests.Related Tickets & Documents
Added/updated tests?
have not been included
Run verifications and test
make verifyis passing (not passing on main either)make testis passing