Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upsteam.md: fonts folder? #43

Open
davelab6 opened this issue Jul 25, 2022 · 3 comments
Open

Upsteam.md: fonts folder? #43

davelab6 opened this issue Jul 25, 2022 · 3 comments

Comments

@davelab6
Copy link
Member

A user wrote me

According to this page I should create fonts folder and upload fonts to GitHub. On the other side, fonts folder is included to .gitignore file: https://github.com/googlefonts/googlefonts-project-template/blob/main/.gitignore

I guess .gitignore should be updated to remove that line.... thoughts @simoncozens ?

@simoncozens
Copy link
Contributor

We need to decide if we are prioritising fonts built locally (and uploaded into, and onboarded from, the repo) or fonts built remotely and packaged using GHA. I have a strong preference for GHA, but we have been ambivalent on this point.

@rsheeter
Copy link
Contributor

In time I want to store sources in google/fonts, no binaries in git at all.

@RosaWagner
Copy link
Contributor

A lot of designers are still not empowered with GHA and tag releases. Also some projects don't fit the template and would need to customise the action (which can be complicated in some cases). To make sure the template can allow these different scenarios, I would allow what we instruct people to do: having the font folder in their repo.

For the hundreds of fonts that we have onbaorded; using github is already a complicated step for designers, asking them to use github action simply results in not working on github anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants