Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

set #![deny(clippy::arithmetic_side_effects)] in font_types #971

Open
cmyr opened this issue Jun 25, 2024 · 0 comments
Open

set #![deny(clippy::arithmetic_side_effects)] in font_types #971

cmyr opened this issue Jun 25, 2024 · 0 comments

Comments

@cmyr
Copy link
Member

cmyr commented Jun 25, 2024

At the very least in the fixed module, but let's review the whole crate.

From working on #970 it seems that the clippy deny directive does not necessarily capture overflows for our fixed_impl types. When I add that directive, the fvar normalization still compiles and the directive does not capture the potential overflow.

Originally posted by @drott in #967 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@cmyr