Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question about traversal feature in read-fonts and skrifa #1062

Open
waywardmonkeys opened this issue Aug 1, 2024 · 1 comment
Open

Question about traversal feature in read-fonts and skrifa #1062

waywardmonkeys opened this issue Aug 1, 2024 · 1 comment

Comments

@waywardmonkeys
Copy link
Contributor

waywardmonkeys commented Aug 1, 2024

I was working on tidying something up and ran across this in skrifa/Cargo.toml:

[features]
default = ["traversal"]
std = ["read-fonts/std"]
traversal = ["std", "read-fonts/traversal"]

and:

[dependencies]
read-fonts = { version = "0.20.0", path = "../read-fonts", default-features = false }

The traversal feature in read-fonts is listed as experimental and it doesn't seem like the code in skrifa is using it at all.

Should it be enabled there by default?

If not, should the default features for skrifa actually be: default = ["std"]?

(The change I was trying out was to use workspace dependencies for all of the crates within the repo so that the version and path aren't being repeated in multiple places, making maintenance a bit easier...)

@cmyr
Copy link
Member

cmyr commented Aug 1, 2024

traversal provides useful impls of Debug for the types in read-fonts, which is useful for skrifa.

It is 'experimental' in the sense that the traversal API is not considered public for the purposes of semver; it is only public so that it can be used by otexplorer, which we are always on the cusp of removing (but which I resist for the time being because it is periodically very useful to me when debugging compilation errors)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants