Use AssertionError(String, Throwable) instead of supplying the cause later.
#1297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
…e later. I could have done this as part of cl/609415936 and cl/604677493, but I'd missed that `AssertionError(String, Throwable)` was [added in API Level 19](https://developer.android.com/reference/java/lang/AssertionError#AssertionError(java.lang.String,%20java.lang.Throwable)). (The code in `Platform` in cl/609415936 still needs to use `initCause` because it uses `ComparisonFailure`, which does not expose a `Throwable`-accepting constructor.) RELNOTES=n/a PiperOrigin-RevId: 638335715
copybara-service
bot
force-pushed
the
test_638262992
branch
from
1d681c9
to
7a1c72f
Compare
copybara-service
bot
closed this pull request by merging all changes
into
master
in
7a1c72f
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
AssertionError(String, Throwable)instead of supplying the cause later.I could have done this as part of cl/609415936 and cl/604677493, but I'd missed that
AssertionError(String, Throwable)was added in API Level 19.(The code in
Platformin cl/609415936 still needs to useinitCausebecause it usesComparisonFailure, which does not expose aThrowable-accepting constructor.)RELNOTES=n/a