Skip to content
This repository has been archived by the owner on Aug 16, 2024. It is now read-only.

modularization #92

Open
sheepdreamofandroids opened this issue Nov 1, 2019 · 3 comments
Open

modularization #92

sheepdreamofandroids opened this issue Nov 1, 2019 · 3 comments

Comments

@sheepdreamofandroids
Copy link
Contributor

I'm feeling that rejoiner could be split into some modules which would make it more generally useful and easier to adapt to different usecases. I'm thinking out loud here so please tell me I'm wrong before I start on a PR ;-)

  1. protobuf -> graphql schema conversion
  2. graphql schema modification (now depends on protobuf)
  3. annotations for 2
  4. binding with guice

Splitting these into maven modules would allow to add these for example:

  1. swagger -> graphql schema conversion
  2. binding with spring

I think the hardest work would be to make the modification part independent of protobuf without losing efficiency.

cheers

@siderakis
Copy link
Member

Hey, we are starting work on the multi-module branch. First step is extracting out rejoined-guice from the core. PRs on that brach are welcome :-)

@sheepdreamofandroids
Copy link
Contributor Author

Hey that's great! It was me threatening with a PR that made you do it, right? ;-)
I'd love to get involved but I'm not sure how to do that without getting into huge merge conflicts.

BTW, I saw that the new module is using gradle. Do you want to move everything to gradle?

@siderakis
Copy link
Member

Yes! also my coworker had a need for things to be modularized too.

I'm thinking of moving everything to maven, gradle would be fine also but supporting one fully is the goal (right now it's a mix).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants