Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Presubmit to check that messages are updated #660

Open
nworden opened this issue Apr 29, 2019 · 0 comments
Open

Presubmit to check that messages are updated #660

nworden opened this issue Apr 29, 2019 · 0 comments

Comments

@nworden
Copy link
Contributor

nworden commented Apr 29, 2019

Since server_tests updates them when it runs, it used to be nearly impossible to neglect this, since they'd get updated as long as you ran the server tests locally before you opened your PR. However, with the Django migration, we're moving away from the current server testing framework and using Django's test framework instead. Overall that's been really nice, because the Django tests are way faster, but it does mean you can forget to update messages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant