-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generate RegionCode constants for testing. #3623
Open
silvio2402
wants to merge
6
commits into
google:master
Choose a base branch
from
silvio2402:auto-gen-regioncode
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tvislavski
reviewed
Sep 11, 2024
java/libphonenumber/test/com/google/i18n/phonenumbers/RegionCode.java
Outdated
Show resolved
Hide resolved
tools/java/java-build/src/com/google/i18n/phonenumbers/BuildMetadataProtoFromXml.java
Outdated
Show resolved
Hide resolved
tools/java/java-build/src/com/google/i18n/phonenumbers/BuildMetadataProtoFromXml.java
Outdated
Show resolved
Hide resolved
tools/java/java-build/src/com/google/i18n/phonenumbers/BuildMetadataProtoFromXml.java
Outdated
Show resolved
Hide resolved
tools/java/java-build/src/com/google/i18n/phonenumbers/BuildMetadataProtoFromXml.java
Outdated
Show resolved
Hide resolved
tvislavski
reviewed
Sep 12, 2024
java/libphonenumber/test/com/google/i18n/phonenumbers/RegionCode.java
Outdated
Show resolved
Hide resolved
tools/java/java-build/src/com/google/i18n/phonenumbers/BuildMetadataProtoFromXml.java
Outdated
Show resolved
Hide resolved
tvislavski
previously approved these changes
Sep 13, 2024
tools/java/java-build/src/com/google/i18n/phonenumbers/BuildMetadataProtoFromXml.java
Outdated
Show resolved
Hide resolved
mandlil
previously approved these changes
Sep 17, 2024
silvio2402
force-pushed
the
auto-gen-regioncode
branch
from
September 18, 2024 07:17
21c08b0
to
0aa08f7
Compare
tvislavski
approved these changes
Sep 18, 2024
mandlil
approved these changes
Sep 19, 2024
silvio2402
force-pushed
the
auto-gen-regioncode
branch
from
September 20, 2024 14:38
6748de4
to
c8c3771
Compare
This generates the RegionCode class that contains string constants for testing using the build tools. Context: b/237181793
silvio2402
force-pushed
the
auto-gen-regioncode
branch
from
September 26, 2024 09:46
c8c3771
to
bbce4a4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This generates the RegionCode class that contains string constants for testing using the build tools.
Context: b/237181793