Non-tools builds fail linking on Linux with ld.gold

[akien-mga]

Godot version:
3.2 master (1d5ae6d) after #24086

OS/device including version:
Mageia 7 x86_64

$ gcc --version | head -n 1
gcc (Mageia 8.3.1-0.20190524.1.mga7) 8.3.1 20190524
$ ld.gold --version | head -n 1
GNU gold (GNU Binutils 2.32) 1.16

Issue description:
When compiling with ld.gold as linker, the linking step fails with:

Linking Program        ==> bin/godot.x11.opt.64
/bin/ld.gold: error: platform/x11/pck_embed.ld:10:8: syntax error, unexpected STRING
/bin/ld.gold: fatal error: unable to parse script file platform/x11/pck_embed.ld
collect2: error: ld returned 1 exit status

It works fine with ld (GNU ld (GNU Binutils) 2.32).

CC @RandomShaper

Steps to reproduce:

• Make sure you have ld.gold installed and in PATH
• scons p=x11 LINKFLAGS=-fuse-ld=gold tools=no target=release

[akien-mga]

For the reference, it links fine with LLD (use_llvm=yes use_lld=yes).

[creikey]

This stackoverflow answer seems to have some pointers to using gold: https://stackoverflow.com/questions/3476093/replacing-ld-with-gold-any-experience

[Anutrix]

The initial design of gold meant to not support any linker scripts. Then
they end up supporting some cases, but "INSERT BEFORE .data" is not one of
them if I remember correctly.

Source: clang-omp/clang_trunk#30 (comment)
Maybe the build is failing because gold just doesn't support BEFORE and AFTER.
Note: I wasn't able to confirm or deny the above statement in the quote.

[KoBeWi]

Can anyone still reproduce this bug in Godot 3.2.3 or any later release?

[akien-mga]

Yes, the same method is still used with a linker script for the PCK bundling option, which is incompatible with ld.gold. So it's reproducible both in master and 3.2, but it's fairly low priority.

[RandomShaper]

I hope I can allocate some time soon to rework the PCK embedding so we can remove the current fragile approach.

[akien-mga]

For the reference this is still reproducible... but also not very critical. I'm fine if we want to close this as WONTFIX and just let it be documented by the closed issue. We don't use ld.gold for official builds.

[RandomShaper]

I've not been able to allocate time for this. Feel free to close it. It's in my to do list, though, so it will be fixed one day. 😃

[akien-mga]

Yeah I think we can close it. It will be fixed as a side effect when we refactor PCK embedding, but the problem with ld.gold specifically is not worth keeping track of.