Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

how to disable request log with REQUEST(curl) when set debug to true #834

Closed
BoneAsh opened this issue Aug 29, 2024 · 4 comments
Closed
Assignees
Milestone

Comments

@BoneAsh
Copy link

BoneAsh commented Aug 29, 2024

I need to PUT request with large body as upload file, debug logger request body by "Body: r.fmtBodyString(c.debugBodySizeLimit)" , it will logger fmt.Sprintf("***** REQUEST TOO LARGE (size - %d) *****", bodySize) where body is too large, but REQUEST(curl) will logger full body.

@jeevatkm
Copy link
Member

@BoneAsh Thanks for reaching out. CURL command logging requires the entire body. However, it can be a bad experience for users who only need debug logging.

I'm planning to implement another option as part of #828 to separate it like this -

  • Debug log (same as before the CURL command feature was added)
  • Debug log with CURL command log enabled

@jeevatkm jeevatkm self-assigned this Sep 3, 2024
@jeevatkm jeevatkm added this to the v2.15.0 milestone Sep 3, 2024
@jeevatkm
Copy link
Member

jeevatkm commented Sep 3, 2024

@BoneAsh, I have merged the PR to fix #828; you can pin the branch version for now.

@BoneAsh
Copy link
Author

BoneAsh commented Sep 4, 2024

@BoneAsh, I have merged the PR to fix #828; you can pin the branch version for now.

ok, i will try

@BoneAsh
Copy link
Author

BoneAsh commented Sep 4, 2024

yeah, the generateCurlOnDebug flag is useful, I will close this issue, thank you @jeevatkm

@BoneAsh BoneAsh closed this as completed Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants