Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scroll view scrolling not working in side the <GestureRecognizer> #72

Open
Anunest opened this issue Sep 7, 2021 · 4 comments
Open

Comments

@Anunest
Copy link

Anunest commented Sep 7, 2021

No description provided.

@amartyach98
Copy link

Hi @Anunest have you got any solution for this issue?

@MerijnCanvas
Copy link

@amartyach98 If you still want this fixed, you could try and install my forked repo via npm install MerijnCanvas/react-native-swipe-gestures

@Joseph-D-Bradshaw
Copy link

I have got mine working inside of a ScrollView just fine, anything in particular that caused your issue?

@johnslobodan07
Copy link

Here is the diff that solved my problem:

diff --git a/node_modules/react-native-swipe-gestures/index.js b/node_modules/react-native-swipe-gestures/index.js
index 38d1db5..fd94b51 100644
--- a/node_modules/react-native-swipe-gestures/index.js
+++ b/node_modules/react-native-swipe-gestures/index.js
@@ -58,8 +58,8 @@ class GestureRecognizer extends Component {
 
   _gestureIsClick(gestureState) {
     return (
-      Math.abs(gestureState.dx) < swipeConfig.gestureIsClickThreshold &&
-      Math.abs(gestureState.dy) < swipeConfig.gestureIsClickThreshold
+      Math.abs(gestureState.dx) < swipeConfig.gestureIsClickThreshold 
+      //&& Math.abs(gestureState.dy) < swipeConfig.gestureIsClickThreshold
     );
   }
 

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants