From 53897ff5d42bad05622e5ae53d026758fd28201c Mon Sep 17 00:00:00 2001 From: Anton Pirker Date: Wed, 11 Sep 2024 11:04:16 +0200 Subject: [PATCH] Update Codecov config (#3507) The Codecov plugins somehow changing our coverage reports, which lead to incorrect coverage measurements. This change will disable all Codecov plugins so our uploaded coverage reports will not be altered. According to Codecov engineers, this has no downsides. --- .github/workflows/test-integrations-ai.yml | 8 ++++++++ .github/workflows/test-integrations-aws-lambda.yml | 4 ++++ .github/workflows/test-integrations-cloud-computing.yml | 8 ++++++++ .github/workflows/test-integrations-common.yml | 4 ++++ .github/workflows/test-integrations-data-processing.yml | 8 ++++++++ .github/workflows/test-integrations-databases.yml | 8 ++++++++ .github/workflows/test-integrations-graphql.yml | 8 ++++++++ .github/workflows/test-integrations-miscellaneous.yml | 8 ++++++++ .github/workflows/test-integrations-networking.yml | 8 ++++++++ .github/workflows/test-integrations-web-frameworks-1.yml | 8 ++++++++ .github/workflows/test-integrations-web-frameworks-2.yml | 8 ++++++++ scripts/split-tox-gh-actions/templates/test_group.jinja | 6 +++++- 12 files changed, 85 insertions(+), 1 deletion(-) diff --git a/.github/workflows/test-integrations-ai.yml b/.github/workflows/test-integrations-ai.yml index c3c8f7a689..18b6e8e641 100644 --- a/.github/workflows/test-integrations-ai.yml +++ b/.github/workflows/test-integrations-ai.yml @@ -82,12 +82,16 @@ jobs: with: token: ${{ secrets.CODECOV_TOKEN }} files: coverage.xml + # make sure no plugins alter our coverage reports + plugin: noop + verbose: true - name: Upload test results to Codecov if: ${{ !cancelled() }} uses: codecov/test-results-action@v1 with: token: ${{ secrets.CODECOV_TOKEN }} files: .junitxml + verbose: true test-ai-pinned: name: AI (pinned) timeout-minutes: 30 @@ -150,12 +154,16 @@ jobs: with: token: ${{ secrets.CODECOV_TOKEN }} files: coverage.xml + # make sure no plugins alter our coverage reports + plugin: noop + verbose: true - name: Upload test results to Codecov if: ${{ !cancelled() }} uses: codecov/test-results-action@v1 with: token: ${{ secrets.CODECOV_TOKEN }} files: .junitxml + verbose: true check_required_tests: name: All AI tests passed needs: test-ai-pinned diff --git a/.github/workflows/test-integrations-aws-lambda.yml b/.github/workflows/test-integrations-aws-lambda.yml index 10e319f8a2..72ffee0492 100644 --- a/.github/workflows/test-integrations-aws-lambda.yml +++ b/.github/workflows/test-integrations-aws-lambda.yml @@ -101,12 +101,16 @@ jobs: with: token: ${{ secrets.CODECOV_TOKEN }} files: coverage.xml + # make sure no plugins alter our coverage reports + plugin: noop + verbose: true - name: Upload test results to Codecov if: ${{ !cancelled() }} uses: codecov/test-results-action@v1 with: token: ${{ secrets.CODECOV_TOKEN }} files: .junitxml + verbose: true check_required_tests: name: All AWS Lambda tests passed needs: test-aws_lambda-pinned diff --git a/.github/workflows/test-integrations-cloud-computing.yml b/.github/workflows/test-integrations-cloud-computing.yml index 94dd3473cd..3fdc46f88b 100644 --- a/.github/workflows/test-integrations-cloud-computing.yml +++ b/.github/workflows/test-integrations-cloud-computing.yml @@ -78,12 +78,16 @@ jobs: with: token: ${{ secrets.CODECOV_TOKEN }} files: coverage.xml + # make sure no plugins alter our coverage reports + plugin: noop + verbose: true - name: Upload test results to Codecov if: ${{ !cancelled() }} uses: codecov/test-results-action@v1 with: token: ${{ secrets.CODECOV_TOKEN }} files: .junitxml + verbose: true test-cloud_computing-pinned: name: Cloud Computing (pinned) timeout-minutes: 30 @@ -142,12 +146,16 @@ jobs: with: token: ${{ secrets.CODECOV_TOKEN }} files: coverage.xml + # make sure no plugins alter our coverage reports + plugin: noop + verbose: true - name: Upload test results to Codecov if: ${{ !cancelled() }} uses: codecov/test-results-action@v1 with: token: ${{ secrets.CODECOV_TOKEN }} files: .junitxml + verbose: true check_required_tests: name: All Cloud Computing tests passed needs: test-cloud_computing-pinned diff --git a/.github/workflows/test-integrations-common.yml b/.github/workflows/test-integrations-common.yml index dbb3cb5d53..a64912b14d 100644 --- a/.github/workflows/test-integrations-common.yml +++ b/.github/workflows/test-integrations-common.yml @@ -66,12 +66,16 @@ jobs: with: token: ${{ secrets.CODECOV_TOKEN }} files: coverage.xml + # make sure no plugins alter our coverage reports + plugin: noop + verbose: true - name: Upload test results to Codecov if: ${{ !cancelled() }} uses: codecov/test-results-action@v1 with: token: ${{ secrets.CODECOV_TOKEN }} files: .junitxml + verbose: true check_required_tests: name: All Common tests passed needs: test-common-pinned diff --git a/.github/workflows/test-integrations-data-processing.yml b/.github/workflows/test-integrations-data-processing.yml index 6eb3a9f71f..b38c9179e1 100644 --- a/.github/workflows/test-integrations-data-processing.yml +++ b/.github/workflows/test-integrations-data-processing.yml @@ -96,12 +96,16 @@ jobs: with: token: ${{ secrets.CODECOV_TOKEN }} files: coverage.xml + # make sure no plugins alter our coverage reports + plugin: noop + verbose: true - name: Upload test results to Codecov if: ${{ !cancelled() }} uses: codecov/test-results-action@v1 with: token: ${{ secrets.CODECOV_TOKEN }} files: .junitxml + verbose: true test-data_processing-pinned: name: Data Processing (pinned) timeout-minutes: 30 @@ -178,12 +182,16 @@ jobs: with: token: ${{ secrets.CODECOV_TOKEN }} files: coverage.xml + # make sure no plugins alter our coverage reports + plugin: noop + verbose: true - name: Upload test results to Codecov if: ${{ !cancelled() }} uses: codecov/test-results-action@v1 with: token: ${{ secrets.CODECOV_TOKEN }} files: .junitxml + verbose: true check_required_tests: name: All Data Processing tests passed needs: test-data_processing-pinned diff --git a/.github/workflows/test-integrations-databases.yml b/.github/workflows/test-integrations-databases.yml index eca776d1c4..cc93461b6a 100644 --- a/.github/workflows/test-integrations-databases.yml +++ b/.github/workflows/test-integrations-databases.yml @@ -105,12 +105,16 @@ jobs: with: token: ${{ secrets.CODECOV_TOKEN }} files: coverage.xml + # make sure no plugins alter our coverage reports + plugin: noop + verbose: true - name: Upload test results to Codecov if: ${{ !cancelled() }} uses: codecov/test-results-action@v1 with: token: ${{ secrets.CODECOV_TOKEN }} files: .junitxml + verbose: true test-databases-pinned: name: Databases (pinned) timeout-minutes: 30 @@ -196,12 +200,16 @@ jobs: with: token: ${{ secrets.CODECOV_TOKEN }} files: coverage.xml + # make sure no plugins alter our coverage reports + plugin: noop + verbose: true - name: Upload test results to Codecov if: ${{ !cancelled() }} uses: codecov/test-results-action@v1 with: token: ${{ secrets.CODECOV_TOKEN }} files: .junitxml + verbose: true check_required_tests: name: All Databases tests passed needs: test-databases-pinned diff --git a/.github/workflows/test-integrations-graphql.yml b/.github/workflows/test-integrations-graphql.yml index c89423327a..39b4aa5449 100644 --- a/.github/workflows/test-integrations-graphql.yml +++ b/.github/workflows/test-integrations-graphql.yml @@ -78,12 +78,16 @@ jobs: with: token: ${{ secrets.CODECOV_TOKEN }} files: coverage.xml + # make sure no plugins alter our coverage reports + plugin: noop + verbose: true - name: Upload test results to Codecov if: ${{ !cancelled() }} uses: codecov/test-results-action@v1 with: token: ${{ secrets.CODECOV_TOKEN }} files: .junitxml + verbose: true test-graphql-pinned: name: GraphQL (pinned) timeout-minutes: 30 @@ -142,12 +146,16 @@ jobs: with: token: ${{ secrets.CODECOV_TOKEN }} files: coverage.xml + # make sure no plugins alter our coverage reports + plugin: noop + verbose: true - name: Upload test results to Codecov if: ${{ !cancelled() }} uses: codecov/test-results-action@v1 with: token: ${{ secrets.CODECOV_TOKEN }} files: .junitxml + verbose: true check_required_tests: name: All GraphQL tests passed needs: test-graphql-pinned diff --git a/.github/workflows/test-integrations-miscellaneous.yml b/.github/workflows/test-integrations-miscellaneous.yml index 492338c40e..369e6afd87 100644 --- a/.github/workflows/test-integrations-miscellaneous.yml +++ b/.github/workflows/test-integrations-miscellaneous.yml @@ -82,12 +82,16 @@ jobs: with: token: ${{ secrets.CODECOV_TOKEN }} files: coverage.xml + # make sure no plugins alter our coverage reports + plugin: noop + verbose: true - name: Upload test results to Codecov if: ${{ !cancelled() }} uses: codecov/test-results-action@v1 with: token: ${{ secrets.CODECOV_TOKEN }} files: .junitxml + verbose: true test-miscellaneous-pinned: name: Miscellaneous (pinned) timeout-minutes: 30 @@ -150,12 +154,16 @@ jobs: with: token: ${{ secrets.CODECOV_TOKEN }} files: coverage.xml + # make sure no plugins alter our coverage reports + plugin: noop + verbose: true - name: Upload test results to Codecov if: ${{ !cancelled() }} uses: codecov/test-results-action@v1 with: token: ${{ secrets.CODECOV_TOKEN }} files: .junitxml + verbose: true check_required_tests: name: All Miscellaneous tests passed needs: test-miscellaneous-pinned diff --git a/.github/workflows/test-integrations-networking.yml b/.github/workflows/test-integrations-networking.yml index fb55e708ae..cb032f0ef4 100644 --- a/.github/workflows/test-integrations-networking.yml +++ b/.github/workflows/test-integrations-networking.yml @@ -78,12 +78,16 @@ jobs: with: token: ${{ secrets.CODECOV_TOKEN }} files: coverage.xml + # make sure no plugins alter our coverage reports + plugin: noop + verbose: true - name: Upload test results to Codecov if: ${{ !cancelled() }} uses: codecov/test-results-action@v1 with: token: ${{ secrets.CODECOV_TOKEN }} files: .junitxml + verbose: true test-networking-pinned: name: Networking (pinned) timeout-minutes: 30 @@ -142,12 +146,16 @@ jobs: with: token: ${{ secrets.CODECOV_TOKEN }} files: coverage.xml + # make sure no plugins alter our coverage reports + plugin: noop + verbose: true - name: Upload test results to Codecov if: ${{ !cancelled() }} uses: codecov/test-results-action@v1 with: token: ${{ secrets.CODECOV_TOKEN }} files: .junitxml + verbose: true check_required_tests: name: All Networking tests passed needs: test-networking-pinned diff --git a/.github/workflows/test-integrations-web-frameworks-1.yml b/.github/workflows/test-integrations-web-frameworks-1.yml index 01b391992d..f6a94e6d08 100644 --- a/.github/workflows/test-integrations-web-frameworks-1.yml +++ b/.github/workflows/test-integrations-web-frameworks-1.yml @@ -96,12 +96,16 @@ jobs: with: token: ${{ secrets.CODECOV_TOKEN }} files: coverage.xml + # make sure no plugins alter our coverage reports + plugin: noop + verbose: true - name: Upload test results to Codecov if: ${{ !cancelled() }} uses: codecov/test-results-action@v1 with: token: ${{ secrets.CODECOV_TOKEN }} files: .junitxml + verbose: true test-web_frameworks_1-pinned: name: Web Frameworks 1 (pinned) timeout-minutes: 30 @@ -178,12 +182,16 @@ jobs: with: token: ${{ secrets.CODECOV_TOKEN }} files: coverage.xml + # make sure no plugins alter our coverage reports + plugin: noop + verbose: true - name: Upload test results to Codecov if: ${{ !cancelled() }} uses: codecov/test-results-action@v1 with: token: ${{ secrets.CODECOV_TOKEN }} files: .junitxml + verbose: true check_required_tests: name: All Web Frameworks 1 tests passed needs: test-web_frameworks_1-pinned diff --git a/.github/workflows/test-integrations-web-frameworks-2.yml b/.github/workflows/test-integrations-web-frameworks-2.yml index 310921a250..0a66e98d3d 100644 --- a/.github/workflows/test-integrations-web-frameworks-2.yml +++ b/.github/workflows/test-integrations-web-frameworks-2.yml @@ -102,12 +102,16 @@ jobs: with: token: ${{ secrets.CODECOV_TOKEN }} files: coverage.xml + # make sure no plugins alter our coverage reports + plugin: noop + verbose: true - name: Upload test results to Codecov if: ${{ !cancelled() }} uses: codecov/test-results-action@v1 with: token: ${{ secrets.CODECOV_TOKEN }} files: .junitxml + verbose: true test-web_frameworks_2-pinned: name: Web Frameworks 2 (pinned) timeout-minutes: 30 @@ -190,12 +194,16 @@ jobs: with: token: ${{ secrets.CODECOV_TOKEN }} files: coverage.xml + # make sure no plugins alter our coverage reports + plugin: noop + verbose: true - name: Upload test results to Codecov if: ${{ !cancelled() }} uses: codecov/test-results-action@v1 with: token: ${{ secrets.CODECOV_TOKEN }} files: .junitxml + verbose: true check_required_tests: name: All Web Frameworks 2 tests passed needs: test-web_frameworks_2-pinned diff --git a/scripts/split-tox-gh-actions/templates/test_group.jinja b/scripts/split-tox-gh-actions/templates/test_group.jinja index e63d6e0235..66834f9ef2 100644 --- a/scripts/split-tox-gh-actions/templates/test_group.jinja +++ b/scripts/split-tox-gh-actions/templates/test_group.jinja @@ -96,10 +96,14 @@ with: token: {% raw %}${{ secrets.CODECOV_TOKEN }}{% endraw %} files: coverage.xml + # make sure no plugins alter our coverage reports + plugin: noop + verbose: true - name: Upload test results to Codecov if: {% raw %}${{ !cancelled() }}{% endraw %} uses: codecov/test-results-action@v1 with: token: {% raw %}${{ secrets.CODECOV_TOKEN }}{% endraw %} - files: .junitxml \ No newline at end of file + files: .junitxml + verbose: true \ No newline at end of file