Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redis: One Pool per usecase #3829

Open
Dav1dde opened this issue Jul 18, 2024 · 2 comments
Open

Redis: One Pool per usecase #3829

Dav1dde opened this issue Jul 18, 2024 · 2 comments
Assignees
@loewenheim

Comments

@Dav1dde
Copy link
Member

Dav1dde commented Jul 18, 2024

We should split the Regex pools into multiple pools, one per usecase:

  • Project Config
  • Cardinality
  • Quotas
  • Misc (metric meta)

The configuration should accept the config we already have and use that to configure each pool with these values or share the same pool for all usecases (tbd).

Additionally the config should accept a config for each pool with different configuration values.
@Dav1dde Dav1dde mentioned this issue Jul 18, 2024
Open
@loewenheim
Copy link
Contributor

Can you reiterate which services (EnvelopeProcessor, ProjectCache, RelayStats) need access to which Redis pools?

@loewenheim loewenheim self-assigned this Jul 19, 2024
@loewenheim loewenheim mentioned this issue Jul 19, 2024
Merged
@Dav1dde
Copy link
Member Author

Dav1dde commented Jul 19, 2024 •
edited
Loading

  • ProjectCache needs project configs
  • RelayStats needs all pods (it just exports pool metrics via statsd, we want these stats for all pools)
  • EnvelopeProcessor needs cardinality, quotas and misc (metric meta)

loewenheim added a commit that referenced this issue Jul 24, 2024
@loewenheim
feat(redis): Allow configuring Redis pools individually (#3843)
4594b39 
Implements #3829.
@loewenheim loewenheim mentioned this issue Jul 24, 2024
Merged
loewenheim added a commit that referenced this issue Aug 1, 2024
@loewenheim
feat(redis): Allow configuring Redis pools individually (#3859)
824cdb2 
Second attempt at #3843.
Implements #3829.

This time around, if there is only one Redis pool configuration, we only
create one pool and clone it 4 ways (instead of creating 4 identical
pools like last time). This means that the case of only one
configuration preserves the current behavior, modulo the bug fix related
to `DEFAULT_MIN_MAX_CONNECTIONS`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@loewenheim loewenheim

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Dav1dde @loewenheim