Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated App design #2

Open
bumi opened this issue Jan 9, 2022 · 8 comments · Fixed by #7
Open

Updated App design #2

bumi opened this issue Jan 9, 2022 · 8 comments · Fixed by #7

Comments

@bumi
Copy link
Contributor

bumi commented Jan 9, 2022

We got this design suggestions for the app
image
image (1)
.
We must always reuse any default macOS style and not do anything custom but I guess we can add some background image/color the logo etc.

Please also note that the amount of browsers shown depends on the browser installed on the user's system.

@stuffmc
Copy link
Collaborator

stuffmc commented Jan 9, 2022

These are great designs, but:

  • How does it look in Dark mode?
  • These aren't the Chrome/Chromium Icons on macOS*

No more "1" and "2" like on your original "design"?

  • We certainly can package the Icons in the App, but I'd rather keep on reading it from the App as those icons might change in the future and confuse the users. One option would be to pick the same background as the Chrome Icon. Not sure if that would work and the size of the Icons would also be different anyways.

@bumi
Copy link
Contributor Author

bumi commented Jan 9, 2022

These images are just inspiration. We do not want to package the icons and keep it as you have built it. that is best!

So here is mainly the idea to add that header with the Alby logo and a bit text I guess.
Leaving this up to the designers :)

@stuffmc
Copy link
Collaborator

stuffmc commented Jan 9, 2022

I don't think we need more designers than the designs that are there. We have all the necessary. I prefer design 1, since the straight buttons are slightly boring. Let's make that happen as part of the next release.

@bumi
Copy link
Contributor Author

bumi commented Jan 9, 2022

so design 1 it is.

  • we use the Browser logos as you already load it
  • we need to use the proper Alby logo
  • make sure it works on dark mode

@VihlayewAlex VihlayewAlex mentioned this issue Jan 14, 2022
@stuffmc
Copy link
Collaborator

stuffmc commented Jan 17, 2022

Reopen this because right now it doesn't work in Dark mode because of .preferredColorScheme(.light) (which should be removed in the future — this is a downgrade) and the Color( in the code. We shall not use Color in the code but instead Color Assets that will adapt automatically.

@stuffmc stuffmc reopened this Jan 17, 2022
@bumi
Copy link
Contributor Author

bumi commented Jan 28, 2022

@johnsBeharry should we use there this logo or the one we have everywhere with the normal eyes?

@stuffmc
Copy link
Collaborator

stuffmc commented Jan 28, 2022

Oh good catch, @bumi! I didn't see that. I prefer the one with the real eyes, and it's also the one on https://getalby.com. As for the dark mode, I've added a first version of it, which we could change (especially the background color), and I think the Icon should be available with a white background instead of black, potentially. Speaking of Darkmode, I don't think the HTML/CSS in the extension respects Dark mode, but that'd be another ticket.

@johnsBeharry
Copy link

@bumi i think the idea behind it was that it's for connections / messaging. for consistency though we could. Let me speak with Alex about the branding guidelines

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants