Redundant use of <context:property-placeholder>?

[severo]

I understand that the line:

 <context:property-placeholder location="file:${georchestra.datadir}/geonetwork/geonetwork.properties" file-encoding="UTF-8" ignore-unresolvable="true" order="0"/>

present in three files:

• config-datadir-georchestra.xml
• config-db-georchestra.xml
• config-security-georchestra.xml (note that the line is slightly different here, but I think that it does not change the idea)

should be moved to config-overrides-georchestra.xml in order to avoid multiple loading operations of the same file. And it could allow to add a second file (default.properties, see georchestra/georchestra#2299) with more trust in the priority order (see georchestra/georchestra#2123).

[fvanderbiest]

Agreed.

What's your opinion @pmauduit ? Was there a good reason for not doing so ?

[pmauduit]

What's your opinion @pmauduit ? Was there a good reason for not doing so ?

I thought it was necessary on each and every files that were making use of the variables, but if it is not the case and we can avoid loading the file multiple times, I'm ok with this.

[fvanderbiest]

OK, go ahead @severo