Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Executing tests in Docker is broken #103

Open
captaincoordinates opened this issue Jul 18, 2024 · 0 comments · May be fixed by #104
Open

Executing tests in Docker is broken #103

captaincoordinates opened this issue Jul 18, 2024 · 0 comments · May be fixed by #104

Comments

@captaincoordinates
Copy link
Contributor

captaincoordinates commented Jul 18, 2024 •
edited
Loading

The README's instructions for executing tests in Docker are broken. This is partly because tests/execute-tests.sh was deleted (seemingly without reason) in this commit and partly because the approach has not been maintained in line with new test dependencies.

Personally I would prefer that the GitHub Actions Workflow executed tests using Docker, so that developers can guarantee tests will behave equally in both environments and as an incentive to ensure the Docker approach is maintained, however I appreciate that approach might not be to everyone's taste.

I have a fork that fixes Docker tests and I will submit a PR after creating this issue.

PR #104
captaincoordinates added a commit to captaincoordinates/pygeofilter that referenced this issue Jul 18, 2024
@captaincoordinates
fix(geopython#103): Fix Docker tests
033f9ff
@captaincoordinates captaincoordinates linked a pull request Jul 18, 2024 that will close this issue
Open
captaincoordinates added a commit to captaincoordinates/pygeofilter that referenced this issue Jul 20, 2024
@captaincoordinates
fix(geopython#103): Fix Docker tests
86433a7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix Docker tests captaincoordinates/pygeofilter
1 participant
@captaincoordinates