Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PB-764 made polyfill url configurable via env #4411

Merged
merged 1 commit into from
Jul 5, 2024
Merged

PB-764 made polyfill url configurable via env #4411

merged 1 commit into from
Jul 5, 2024

Conversation

boecklic
Copy link
Contributor

@boecklic boecklic commented Jul 4, 2024

No description provided.

@github-actions github-actions bot added the bug label Jul 4, 2024
@boecklic boecklic force-pushed the fix_PB-764_fix_polyfill branch 2 times, most recently from 4f36f0d to d5c7e75 Compare July 4, 2024 20:43
pakb
pakb approved these changes Jul 5, 2024
View reviewed changes
Copy link
Contributor

@pakb pakb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed with Stefan, IMHO we could ditch the polyfill thing, as it is there to care for browsers way past their age (2013 to 2015).

But what you did fix the issue for the time being, so good that way too

@boecklic boecklic merged commit f2cab88 into master Jul 5, 2024
5 checks passed
@boecklic boecklic deleted the fix_PB-764_fix_polyfill branch July 5, 2024 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pakb pakb pakb approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@boecklic @pakb