Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace flake8 checks with Ruff and show the warning messages onh GH #849

Merged
merged 4 commits into from
Feb 3, 2024

Conversation

rdbende
Copy link
Collaborator

@rdbende rdbende commented Jan 20, 2024

What we discussed in PM @geigi, except that I added Ruff instead, so it finishes much faster. Ruff also has a ton of rules built-in (https://github.com/astral-sh/ruff#rules), so we might need to adjust the --select later.

With the --output-format github it produces outputs in the Files tab of the PR like this:

grafik

After this, we can turn off the Codeclimate checks.

@rdbende
Copy link
Collaborator Author

rdbende commented Jan 20, 2024

I left --exit-zero there for now, so it won't make every PR fail. However it would be good to fix all those warnings it gives in a follow-up pull request, and remove this flag.

@geigi
Copy link
Owner

geigi commented Feb 3, 2024

Awesome :) Ruff looks cool, didn't know it yet! I'll disable Codeclimate

@geigi geigi merged commit 699c10c into master Feb 3, 2024
6 checks passed
@geigi geigi deleted the add-ruff branch February 3, 2024 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants