Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename or alias setPheno() to simPheno() #152

Open
gregorgorjanc opened this issue Aug 21, 2023 · 0 comments
Open

Rename or alias setPheno() to simPheno() #152

gregorgorjanc opened this issue Aug 21, 2023 · 0 comments

Comments

@gregorgorjanc
Copy link
Contributor

Is your feature request related to a problem? Please describe.

I have now seen a couple of cases where users have been thinking that setPheno() will give them the same pheno, wich of course will not happen due to the random error.

Describe the solution you'd like

Maybe renaming (or aliasing) setPheno() to simPheno() would be more didactic approach?

Describe alternatives you've considered

By aliasing and suggesting use of simPheno() instead of setPheno() the older code would not break.

Additional context

We could then look into making simPheno() a generic function with various model extensions in the future ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant