Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: Red Orchestra and Red Orchestra: Ostfront 41-45 should be the same game #616

Open
dgibbs64 opened this issue Aug 18, 2024 · 2 comments · May be fixed by #639
Open

bug: Red Orchestra and Red Orchestra: Ostfront 41-45 should be the same game #616

dgibbs64 opened this issue Aug 18, 2024 · 2 comments · May be fixed by #639
Labels

Comments

@dgibbs64
Copy link
Contributor

Describe the bug
I just noticed that there is both "Red Orchestra" and "Red Orchestra: Ostfront 41-45" listed however I believe these are the same game. I can also confirm that Red Orchestra: Ostfront 41-45 does not use gamespy1 but uses both unreal2 and valve queries (just like Killing Floor 1). I don't believe there was a game simply called Red Orchestra. So IMO this looks like an error and they should be merged.
https://github.com/gamedig/node-gamedig/blob/master/lib/games.js#L2358
https://store.steampowered.com/app/1200/Red_Orchestra_Ostfront_4145

  roo4145: {
    name: 'Red Orchestra: Ostfront 41-45',
    release_year: 2006,
    options: {
      port: 7757,
      port_query_offset: 10,
      protocol: 'unreal2'
    },
    extra: {
      old_id: 'redorchestraost'
    }
  },
@dgibbs64 dgibbs64 added the bug label Aug 18, 2024
@dgibbs64
Copy link
Contributor Author

I have found reference to a game called "Red Orchestra: Combined Arms" which was the original mod

@CosminPerRam
Copy link
Member

The entry (before removing replacing games.txt) was added in this mega commit, I'll too look into it a bit to confirm everything you mentioned (which is really helpful, thanks bunch) and that the PR is a proper fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants