-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NativeGuideCF(method=NG) can return a CF of the same class. #37
Comments
Hi, Looking at your last issue, I think the issue might have been that the input for y into the explain function is an array, although it is supposed to be an int. You can try it with: or instead by adding:
Let me know if it works or if you still need help. |
Hi again, The only case where your fix won't be enough is a very bad classifier f that predicts C for every input. In this scenario, the nearest neighbour will always be from a similar predicted class and method=NG returns a CF within the same class. An idea could be to have a "No CF found" message as it can be the case for method=dtw-barycenter ... ? Anyway, thanks for your help. |
Indeed, that's a really good point. I added a warning that will be available in the next release. Have a good day. |
Hello,
As is it mentioned in this issue's title, I have tried many times the current CF generation in this configuration, and it often generates a CF of the same label than the one predicted already by the the model.
Hope the issue is clear enough !
Thanks
The text was updated successfully, but these errors were encountered: