Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move code into foxbox #59

Open
jedireza opened this issue Mar 7, 2016 · 1 comment
Open

Move code into foxbox #59

jedireza opened this issue Mar 7, 2016 · 1 comment

Comments

@jedireza
Copy link
Contributor

jedireza commented Mar 7, 2016

I read the readme and I can appreicate the intent to make something that can be resued and extended. But right now, the coupling is tight and specific to foxbox and the extra layer of indirection doesn't help us either.

Making a iron-user-module crate is a different goal than building Project Link and I don't think we should sign up for that. I've created a few user systems before 😉 and based on experience, this stuff is better as a boilerplate than of a library/crate.

With that said, I feel strongly that we should merge this repo with foxbox. There should only be 5-6 files to move over into a module directory. I can help doing this.

📟 @fabricedesre @ferjm @arcturus

@ferjm
Copy link
Member

ferjm commented Mar 8, 2016

Although I agree that this is far from being the core goal of Project Link, I still think that there is value on keeping this library external. The fact that it needs to evolve along with Project Link's development and requirements does not mean that the code needs to be specific to it. If things goes the way that they are planned, we will end up with a generic multi-user authentication and authorization system. We need to build it for FoxBox anyway, so why not allow others to reuse our work? IMHO the development cost of having this code external to FoxBox has been quite minimal so far. Could you please point to specific issues that having this code as a library has caused so far?

In any case, I'll defer to @fabricedesre to make the call.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants