Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix LinearRing on innerBoundaryIs for KML Adapter #11

Open
nono303 opened this issue Jan 14, 2024 · 1 comment
Open

fix LinearRing on innerBoundaryIs for KML Adapter #11

nono303 opened this issue Jan 14, 2024 · 1 comment

Comments

@nono303
Copy link

nono303 commented Jan 14, 2024

Hi,
According to https://developers.google.com/kml/documentation/kmlreference?hl=fr#innerboundaryis here is a quick fix for kml adapter

diff --git "a/src/Adapter/KML.php" "b/src/Adapter/KML.php"
index 4b0f959..28b6e84 100644
--- "a/src/Adapter/KML.php"
+++ "b/src/Adapter/KML.php"
@@ -344,7 +344,7 @@ class KML implements GeoAdapter
                 . '</' . $this->nss . 'outerBoundaryIs>';
             foreach (array_slice($components, 1) as $comp) {
                 $str .= '<' . $this->nss . 'innerBoundaryIs>'
-                    . $this->linestringToKML($comp)
+                    . $this->linestringToKML($comp, 'LinearRing')
                     . '</' . $this->nss . 'innerBoundaryIs>';
             }
         }
nono303 pushed a commit to nono303/geoPHP that referenced this issue Oct 4, 2024
@nono303
Copy link
Author

nono303 commented Oct 4, 2024

fixed in my fork nono303@a40b805

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant