Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove direct dependency on Pathom 2 #1

Open
awkay opened this issue Nov 16, 2021 · 2 comments
Open

Remove direct dependency on Pathom 2 #1

awkay opened this issue Nov 16, 2021 · 2 comments
Assignees

Comments

@awkay
Copy link
Member

awkay commented Nov 16, 2021

Follow the pattern in the latest commit of RAD (see attributes and resolver ns) to make it so that this library has no direct need for Pathom 2. The artifacts of P2 are all maps, so there should be no need to make externally visible API changes to do this.

@chrismurrph
Copy link
Collaborator

Locally (ie. I haven't committed) there's now no direct need for P2. However I need to take my lead on this issue from fulcro-rad-datomic. This code (fulcro-rad-kvstore) includes a copy of a recent fulcro-rad-demo. Currently the latest fulcro-rad-demo depends on an old (1.0.9) version of fulcro-rad-datomic. I'd like to see 'everything working at latest'. The specific problem: pathom-plugin now has 2 args, with connection->db being the new 2nd arg. The demo doesn't yet call pathom-plugin with 2 args (in com.example.components.parser).

@chrismurrph chrismurrph self-assigned this Nov 21, 2021
@awkay
Copy link
Member Author

awkay commented Nov 28, 2021

Are you asking for something here, or just writing yourself a note?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants