-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rather than auto update certs, or a cron job. consider Rails.cache.fetch? #6
Comments
Cool! I think you're right. I'm on a new year vacation trip at the moment. Soon as I get back home later this week I will perform a analysis on implementing it. Until there, I will leave it open as you and anyone else can give us more information about it. I will keep this issue updated. |
Well it's quite a good time without improving it. I'm sorry. My current job is getting me a lot of time. I'm going to be very happy If someone pull request it. Otherwise I will need some time before I implement it here. |
Hello. P.S. I am not good at English, so I'm sorry by bad english. |
I'm kinda busy with other projects and a little bit away from Ruby. So I'm afraid I can not help much regarding this subject at the present moment. @penguinwokrs If you or anyone else feel in the mood to proceed with any contributions, it would be just wonderful. You can count with all my support for any questions that may appear during changes. Feel free to contact me via email or by creating GitHub issues here. That being said, I do think that removing Redis is indeed a good option. But let's try also to make it independent from the Rails environment. May be good for it to still support other Ruby applications and frameworks. |
@fschuindt Thank you for me contact. I think this gem is wonderful. |
Hey guys! Are you still working on this? I'm working on implement this feature in my own project, would like to contribute to this gem. |
@namiwang Hi there! I don't hear from @penguinwokrs for a long time, I don't think there's anyone working on it. |
This is really a nice to have. |
Hey guys, sorry for the delay, already implemented the function in one of my private project. It's not actually a fork, just a few methods. Obviously, the impact of using a Personally I see that as an acceptable trade-off, but what do you guys think, an option to use cache or just drop the whole redis-cron solution? BTW maybe we could just depend on |
It's long since any activity here, maybe I'll close this. But for now I'll leave it open with However, if adding Rails is the only way, I think we're better with using Redis. Maybe I can work on this in the future. |
I'm happy to take this on. My idea is to make a new configuration block that would take any FirebaseIdToken.configure do |config|
config.cache_store = ActiveSupport::Cache::MemoryStore.new(namespace: 'foobar')
config.project_ids = ['your-firebase-project-id']
end Any concerns? |
@jdoconnor That looks great. I don't think there are any issues in going with that. Nice idea, btw. |
WIP: #43 |
I was messing around with the gem and it seems like it'd be pretty easy to use Rails.cache.fetch to pull in the new certs if they're expired.
I see a few pros and cons:
Pros:
Cons:
The text was updated successfully, but these errors were encountered: