Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CRAN ERROR for (intended) error in vignette #261

Open
peterdesmet opened this issue Aug 29, 2024 · 2 comments
Open

Fix CRAN ERROR for (intended) error in vignette #261

peterdesmet opened this issue Aug 29, 2024 · 2 comments
Labels
bug Something isn't working documentation Improvements or additions to documentation

Comments

@peterdesmet
Copy link
Member

This vignette has a chunk to show that check_package() will return an (informative) error. The code chuck has the option error = TRUE allowing the vignette to ignore it and continue building.

But it seems to raise an ERROR on CRAN (which has check arguments '--no-clean-on-error '). I'm asking rOpenSci what is the best way to fix this.

@peterdesmet peterdesmet added bug Something isn't working documentation Improvements or additions to documentation labels Aug 29, 2024
@PietrH
Copy link
Member

PietrH commented Aug 29, 2024

Oh, I didn't know about that! No idea on how to get around this, I'm interested to see what the best way to do this is

@peterdesmet
Copy link
Member Author

Got an answer:

I think this is yihui/knitr#2338.
In short, try setting purl = FALSE in chunks with error = TRUE

Indeed, it is only the r-oldrel-macos checks that are failing on CRAN:
Screenshot 2024-08-29 at 17 06 43

I added purl = FALSE, but we will only see the result if we release a patch to CRAN. For now, I'll wait.

@peterdesmet peterdesmet reopened this Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

2 participants