Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use vroom::col_big_integer() for integers to avoid overflow? #212

Open
khusmann opened this issue Jun 26, 2024 · 0 comments
Open

use vroom::col_big_integer() for integers to avoid overflow? #212

khusmann opened this issue Jun 26, 2024 · 0 comments
Labels
complexity:low Likely not complex to implement function:read_resource Function read_resource()
Milestone

Comments

@khusmann
Copy link
Contributor

I notice in #16 you switched from col_integer() to col_double() to avoid integer overflow.

readr doesn't support big integers, but vroom does via vroom::col_big_integer(): https://vroom.r-lib.org/articles/vroom.html#column-types

We may want to try out col_big_integer() out instead of col_double(); it appears to work with the gps data you posted in #16, at least.

@peterdesmet peterdesmet added this to the 1.2.0 milestone Jul 3, 2024
@peterdesmet peterdesmet added function:read_resource Function read_resource() complexity:low Likely not complex to implement labels Jul 3, 2024
@peterdesmet peterdesmet modified the milestones: 1.2.0, 1.3.0 Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
complexity:low Likely not complex to implement function:read_resource Function read_resource()
Projects
None yet
Development

No branches or pull requests

2 participants