meta(parsing): tracking issue for JSON / TOML parsing + writing

[odyslam]

• JSON Parser edge & special cases #3731
• Broken JSON Parsing of Integers #3754
• vm.serializeString might produce numbers #4601
• escaped characters in json are not parsed correctly forge-std#332
• vm.serializeString might produce numbers #4601
• writeJson for Array of Objects forge-std#244 (comment)
• JSON Parser edge & special cases #3731
• Broken JSON Parsing of Integers #3754
• index out of bounds: the len is 0 but the index is 0 #4630 (should be closed soon by fix: handle empty json select #4631)
• bug: serialize & writeJson are not deterministic #4592 (closed, but @sakulstra says it still happens)
• JSON Parsing Docs are Outdated forge-std#372
• vm.parseJson does not revert if key does not exist #5369
• bug: vm.parseJson with static array parses incorrectly #5424
• parseJson with invalid object name reports error in "key" when key parameter is fine #5423
• parseJson with key of "." errors. #5422
• Exclude other cheat inputs/outputs from traces: feat(cheatcodes): add keyExists cheatcode #5431 (comment)
• feat: support parsing .jsonc files #8135
• Cannot keys or values from json object using stdJson.readStringArray #4844
• feat: better JSON parsing #8326
• Allow to parse a JSON and assign its content to an in-memory key #5182
• Add pure JSON serialization cheatcodes  #5764
• bug(cheatcodes): attempting to serialize a number as JSON string will still serialize to a number #6533
• feat: JSON + TOML Parsing with Default Fallbacks #7052
• vm.writeJson should also be able to add new keys  #7232
• feat(cheatcodes): read length of arbitrary array #8467

[mds1]

@odyslam what's the status of this issue? The second item is checked off but issue is opened, so I'm not certain

[sakulstra]

@mds1 the issue with array escaping is still present for sure (just faced on latest forge std and stumbled over this issue)

[mds1]

@odyslam got another one for you here: #4601

[odyslam]

@sakulstra can you elaborate a bit on the array escaping issue and share your code. More use-cases I have, the easier it's to solve this.

I need to prioritize some time to work on these issues

[sakulstra]

@odyslam I refactored the code to no longer use arrays 😅

That said, you can reproduce with this hash 3fb1ca077af827e9138b71d62f2b6f64c8a7b2b7 on https://github.com/bgd-labs/aave-helpers/tree/feat/config-snapshot-v2 by running forge test (json is written to reports folder)

It's this function: https://github.com/bgd-labs/aave-helpers/blob/3fb1ca077af827e9138b71d62f2b6f64c8a7b2b7/src/ProtocolV3TestBase.sol#L78
writing an array e.g. here: https://github.com/bgd-labs/aave-helpers/blob/3fb1ca077af827e9138b71d62f2b6f64c8a7b2b7/src/ProtocolV3TestBase.sol#L299

[mds1]

Got another one from forge-std, full list is below. I haven't triaged these yet, i.e. there may be duplicates, etc.

• escaped characters in json are not parsed correctly forge-std#332
• vm.serializeString might produce numbers #4601
• writeJson for Array of Objects forge-std#244 (comment)
• JSON Parser edge & special cases #3731
• Broken JSON Parsing of Integers #3754
• index out of bounds: the len is 0 but the index is 0 #4630 (should be closed soon by fix: handle empty json select #4631)
• bug: serialize & writeJson are not deterministic #4592 (closed, but @sakulstra says it still happens)
• JSON Parsing Docs are Outdated forge-std#372
• vm.parseJson does not revert if key does not exist #5369
• bug: vm.parseJson with static array parses incorrectly #5424
• parseJson with invalid object name reports error in "key" when key parameter is fine #5423
• parseJson with key of "." errors. #5422
• Exclude other cheat inputs/outputs from traces: feat(cheatcodes): add keyExists cheatcode #5431 (comment)