Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modifier keys and batch operations... #13

Open
ghost opened this issue Nov 28, 2018 · 10 comments
Open

modifier keys and batch operations... #13

ghost opened this issue Nov 28, 2018 · 10 comments

Comments

@ghost
Copy link

ghost commented Nov 28, 2018

so, i'm typing in lowercase right now because i discovered an extremely inconvenient problem with superpng and batch operations - shift/alt keys will open input options even when photoshop is not in focus/minimized/etc, and it does not respect the batch operation option to suppress file open dialogs.

as you might have guessed, i'm running a batch operation right now, one of several i'll need to do tonight

this means that holding down shift to select text in another program can trigger it, or alt tabbing, or, yes, holding shift to capitalize things.

i beg of you to fix this

@oomek
Copy link

oomek commented Nov 28, 2018

I second that. Very annoying. I just go for a fag or a coffee when the batch is running ;)

@ghost
Copy link
Author

ghost commented Nov 28, 2018

thats a bad word and im very offend

@ghost
Copy link
Author

ghost commented Nov 28, 2018

@oomek Any chance you have a build environment that would work for compiling this? I'd love it if you could change it to require both Ctrl and Shift to be held down (and leaving alt out entirely).

It's not ideal but it's a decent enough stopgap measure.

@oomek
Copy link

oomek commented Nov 28, 2018

Don't be. It's how we call ciggarettes here in the UK. But I digress. I've never compiled a Photoshop plugin, but I can try. I also requested one feature a while back (premultipied alpha option on the save dialog box) Maybe now is the time.

@ghost
Copy link
Author

ghost commented Nov 28, 2018

Don't be.

@oomek Don't worry, I was only joking, hence the poor grammar.

I'm looking at the code now, it seems I was mistaken about it accepting the Ctrl key.

bool shift_key = ( KeyIsDown(VK_LSHIFT) || KeyIsDown(VK_RSHIFT) || KeyIsDown(VK_LMENU) || KeyIsDown(VK_RMENU) );

So this line could just be changed to...
bool shift_key = ( KeyIsDown(VK_SHIFT) && KeyIsDown(VK_CONTROL) );

Or to be on the safe side, since there might be a reason he specified the left and right variants separately (Photoshop bug maybe?)...
bool shift_key = ( ( KeyIsDown(VK_LSHIFT) || KeyIsDown(VK_RSHIFT) ) && ( KeyIsDown(VK_LCONTROL) || KeyIsDown(VK_RCONTROL) ) );

@ghost
Copy link
Author

ghost commented Nov 28, 2018

@oomek On second thought, I practically never see alt + shift hotkeys in any program, so let's go with that instead.

bool shift_key = ( ( KeyIsDown(VK_LSHIFT) || KeyIsDown(VK_RSHIFT) ) && ( KeyIsDown(VK_LMENU) || KeyIsDown(VK_RMENU) ) );

@ghost
Copy link
Author

ghost commented Nov 28, 2018

@oomek Having read your feature request for premultipled alpha, I would VERY much like this too.

@oomek
Copy link

oomek commented Nov 28, 2018

I'll give it a go tomorrow or during the weekend.

@oomek
Copy link

oomek commented Nov 29, 2018

@Aidolii please open an issue on my fork https://github.com/oomek/SuperPNG
so we can discuss it further. I've added premultiply alpha to the save dialog, but I'm not sure about suppressing the hotkeys as it also affects the dialog not showing up when you normally open the file.

@ghost
Copy link
Author

ghost commented Nov 30, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant