Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clean folder libfajr/src/data #152

Open
GoogleCodeExporter opened this issue Jul 31, 2015 · 4 comments
Open

clean folder libfajr/src/data #152

GoogleCodeExporter opened this issue Jul 31, 2015 · 4 comments

Comments

@GoogleCodeExporter
Copy link

V priecinku sa pravdepodobne nachadza niekolko nepouzivanych veci.
Kandidati su AIS2TableParser.php, AIS2HTMLParser.php a AIS2ComboBoxParser.php

Treba zistit ci su skutocne potrebne, ak nie zmazat

Original issue reported on code.google.com by [email protected] on 28 Oct 2013 at 10:32

@GoogleCodeExporter
Copy link
Author

AIS2TableParser.php je skutocne dobry kandidat, som si skoro isty, ze ho budeme 
moct v pohode vymazat, rad by som ale naprv vybavil issue 151.

Original comment by [email protected] on 10 Nov 2013 at 9:25

@GoogleCodeExporter
Copy link
Author

AIS2ComboBoxParser.php sa este pouziva v PredmetyFactoryImpl.php, kde sa 
inicializuje a posiela do RegisterPredmetovScreenImpl.php, kde sa aj pouziva na 
ziskanie nejakych options. Mozno sa to da riesit nejako lepsie/jednoduchsie/s 
novsimi komponentami, ale prilis ich nepoznam, takze zatial ho asi bude treba 
nechat.

Original comment by [email protected] on 4 Dec 2013 at 10:12

@GoogleCodeExporter
Copy link
Author

Situacia s AIS2HTMLParser je este hrosia, kedze ho extenduju AIS2TableParser a 
aj AIS2ComboBoxParser. 

Dufal som, ze AIS2TableParser sa bude dat vymazat, ale ukazuje sa, ze tomu tak 
proste nebude. Stale ho pouziva PredmetyFactoryImpl, ktory ho posiela dalej do 
RegisterPredmetovScreenImpl. 

Ostatne miesta, kde sa pouzival som presiel a kde sa nepouziva som ho vyhodil.

Ak by sa podarilo zrefaktorovat RegisterPredmetovScreenImpl a 
PredmetyFactoryImpl (i.e. prepisat pouzitim nejakych novych komponentov), potom 
by sme urcite vedeli lepsie vycistit aj priecinok libfajr/src/data).

Original comment by [email protected] on 4 Dec 2013 at 10:36

@GoogleCodeExporter
Copy link
Author

Super parada, nemal by byt ziadny problem s tym aby sa to nahradilo, skusim sa 
na to mrknut a potom to mozeme vyhodit ;)

Original comment by [email protected] on 4 Dec 2013 at 11:09

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant