Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

logger is broken for utils #90

Open
JaeseungYeom opened this issue Feb 2, 2024 · 2 comments
Open

logger is broken for utils #90

JaeseungYeom opened this issue Feb 2, 2024 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@JaeseungYeom
Copy link
Contributor

I am build it with -DDYAD_LOGGER=FLUX. The compilation error is coming from the attempt to de-reference a NULL pointer.

DYAD_LOG_DEBUG (NULL, "DYAD UTIL: buffer is too small.\n");
      |         ^~~~~~~~~~~~~~
/src/dyad/common/dyad_logging.h:36:57: error: request for member ‘h’ in something not a structure or union
   36 | #define DYAD_LOG_DEBUG(dyad_ctx, ...) flux_log (dyad_ctx->h, LOG_DEBUG, __VA_ARGS__);

Another issue which is separate is the default logger did not record anything when dyad crashed.

@JaeseungYeom JaeseungYeom added the bug Something isn't working label Feb 2, 2024
@JaeseungYeom JaeseungYeom self-assigned this Feb 4, 2024
@JaeseungYeom
Copy link
Contributor Author

PR #91

@JaeseungYeom
Copy link
Contributor Author

In addition, there are different logging that are not part of the main logger framework, DPRINTF and IPRINTF. It is because these are relying on ctx->debug for dynamic control via environment variable. There is a similar logging in DTL as well, These all should be merged into the main logger framework. Also, the debug variable checking should be part of macro such that that conditional does not exist if the logging level is disabled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant