Bug fix for TEF exclusion not honored #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bageshwar
reviewed
Sep 25, 2024
| @@ -107,9 +107,9 @@ | |||
| </build> | |||
|
|
|||
| <properties> | |||
| <revision>0.1.5</revision> | |||
| <revision>0.2.0</revision> | |||
There was a problem hiding this comment.
This should be a minor version bump, since its a bugfix. Refer to semver for guidance.
There was a problem hiding this comment.
This is also JDK17 compliant change.
Hence the bump to major version seemed relevant.
bageshwar
requested changes
Sep 27, 2024
| // The type itself is parameterized | ||
| return ((ParameterizedTypeImpl) genericSuperClass.getActualTypeArguments()[0]).getRawType(); | ||
| return (Class<?>)((ParameterizedType) genericSuperClass.getActualTypeArguments()[0]).getRawType(); |
There was a problem hiding this comment.
Why is this additional cast to Class<?> needed?
|
|
||
| assertNotNull(flow); | ||
|
|
||
| assertEquals(4, flow.getBizlogics().size()); |
There was a problem hiding this comment.
Can you also assert on the order of bizlogics?
|
|
||
| @Override | ||
| public List<Class<? extends IBizlogic>> exclusions() { | ||
| return ImmutableList.of(DataAdapterBizlogic2.class); |
There was a problem hiding this comment.
Given adapter2 was never added to the flow from any place, this exclusion does not test things properly. I think you should add DataAdapterBizlogic2 in adapters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.