Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

macOS Migration does not create notification in notification center after migration dialog closes #19512

Closed
willmayhone88 opened this issue Jun 4, 2024 · 17 comments
Assignees
Labels
bug Something isn't working as documented ~critical bug This is a critical bug and may require a patch release. ~csa Issue was created by or deemed important by the Customer Solutions Architect. #g-mdm MDM product group P1 Prioritize as critical prospect-redwine prospect-velleda :release Ready to write code. Scheduled in a release. See "Making changes" in handbook. ~released bug This bug was found in a stable release.
Milestone

Comments

@willmayhone88
Copy link
Contributor

willmayhone88 commented Jun 4, 2024

Fleet version: Fleet 4.50.2

Web browser and operating system: Safari 17.5 on macOS 14.5


💥  Actual behavior

macOS Migration did not prompt until roughly 35 mins after device was migrated to Fleet server in ABM. After selecting "Turn on MDM" on my device page, no "Device Enrollment" notification is available in the notification center to finish the migration.

🧑‍💻  Steps to reproduce

  1. Ensure mac is on Sonoma 14.5
  2. Have mac enrolled in another MDM
  3. Turn on "Forced" migration and then migrate device in ABM to Fleet server
  4. Wait until "Migrate to Fleet" screen pops up and select "Start"
  5. After my device page pops up, select "Turn on MDM"

🕯️ More info (optional)

This was verified on an M1 Macbook Air, running Sonoma 14.5. Will downgrade device to Ventura and test again.

🛠️ To fix

Product changes: Figma link

@willmayhone88 willmayhone88 added bug Something isn't working as documented :reproduce Involves documenting reproduction steps in the issue :incoming New issue in triage process. labels Jun 4, 2024
@willmayhone88
Copy link
Contributor Author

Adding orbit.stderr.log to this. orbit.stderr.log
Device migrated in ABM at 4:54pm and did not receive migration workflow until 5:22, no notification
ever appeared and roughly every 20 minutes I receive the "Migrate to Fleet" screen.

@georgekarrv georgekarrv added #g-mdm MDM product group :release Ready to write code. Scheduled in a release. See "Making changes" in handbook. and removed :reproduce Involves documenting reproduction steps in the issue labels Jun 5, 2024
@roperzh roperzh assigned roperzh and unassigned roperzh Jun 5, 2024
@willmayhone88
Copy link
Contributor Author

Testing on macOS 14.4:
Migration workflow showed after 22 minutes. But resulted in a different error, logs attached. Was able to manually enroll, but no notification in notification center ever appeared. Device is a personal device that was added to ABM via Apple Configurator.
orbit.stderr 4.log
fleet-desktop.log

@lukeheath lukeheath added P2 Prioritize as urgent ~released bug This bug was found in a stable release. labels Jun 7, 2024
@marko-lisica
Copy link
Member

Follow up on what we discussed today. @gillespi314 @noahtalerman

We want the same experience as we have today on macOS < 14. Run a job (every 15 minutes assuming that's how often it runs currently) that will trigger a command to popup new "Remote Management" dialog.

We want to change instructions on my device page for macOS hosts above 14.0. I'll have the wireframes ready tomorrow.

@roperzh
Copy link
Member

roperzh commented Jun 10, 2024

@marko-lisica @noahtalerman the way this currently works is:

  1. we show our own (swiftDialog) modal that takes over the screen every 15 minutes.
  2. we run the sudo profiles renew --type enrollment command every 1 hour.
    1. In macOS < 14 this shows the notification
    2. In macOS > 14 this opens the native UI that takes over the screen

are you saying that we should run sudo profiles renew --type enrollment after the user clicks our swiftDialog modal so the macOS UI appears afterwards? or are you saying that for macOS > 14 we should just show the native UI instead?

cc: @gillespi314

noahtalerman added a commit that referenced this issue Jun 10, 2024
- Add section for testing the [default migration workflow](https://fleetdm.com/docs/using-fleet/mdm-migration-guide#default-workflow) for macOS hosts.

Discussed w/ @georgekarrv that we may have caught the following bug if we were testing the migration workflow each release: #19512

We also thought it was a good idea to make this part of release QA in case the flow breaks w/ a never version of macOS.
@marko-lisica
Copy link
Member

marko-lisica commented Jun 11, 2024

are you saying that we should run sudo profiles renew --type enrollment after the user clicks our swiftDialog modal so the macOS UI appears afterwards?

@roperzh Sorry if I confused you with the previous message. We want to keep it the same way it is today. Fleet dialog won't trigger sudo profiles renew --type enrollment.

  • We should trigger the command as we do currently, by running the job (just fix the way we call it so it actually works).
  • Additionally we want to improve copy and have it different for hosts with macOS > 14.

I filed a feature request to track the improvement of that flow so possibly it appears when the user clicks a button in the Fleet dialog or on My device page.

cc @gillespi314

@marko-lisica
Copy link
Member

marko-lisica commented Jun 11, 2024

@gillespi314 I just added wireframes to "To fix" section in the bug description.

I relied a lot on this article that describes a new experience, could you double-check that everything described in the wireframes is what end-user will actually experience. More specifically:

  • Apple's dialog appears and after user hit Not now it's triggered by Fleet every hour, after 8 hours user can't dismiss it anymore and Not now button is not available
  • Workflow where user enrolls host using System Settings > Enroll in Remote Menagement sidebar menu item

@noahtalerman Could you take another look on the copy?

@noahtalerman
Copy link
Member

noahtalerman commented Jun 11, 2024

Hey @marko-lisica do you know what this step is? Is it enabled by default? And how does the IT admin enable/disable it? Automatic enrollment (DEP) profile?

Screenshot 2024-06-11 at 2 24 05 PM

Screenshot 2024-06-11 at 2 24 26 PM

If it's not enabled by default I think we can cut this step 4 for now. But we should understand how the IT admin enables/disables it.

@gillespi314 when you get the chance, can you please confirm whether this step doesn't appear by default? Thanks :)

@nonpunctual nonpunctual added the ~csa Issue was created by or deemed important by the Customer Solutions Architect. label Jun 11, 2024
@gillespi314
Copy link
Contributor

@marko-lisica

Apple's dialog appears and after user hit Not now it's triggered by Fleet every hour, after 8 hours user can't dismiss it anymore and Not now button is not available

I have confirmed that it is triggered by Fleet every hour. Later today, I should be able to confirm what happens at the 8 hour mark.

Workflow where user enrolls host using System Settings > Enroll in Remote Menagement sidebar menu item

The screenshots all track with what I've experienced. Regarding Noah's question above, that specific screen doesn't appear with our workflow. Rather the user would see the IdP and EULA screens (same as if it were a new device in the out-of-the-box ADE flow).

@noahtalerman
Copy link
Member

Regarding Noah's question above, that specific screen doesn't appear with our workflow. Rather the user would see the IdP and EULA screens (same as if it were a new device in the out-of-the-box ADE flow).

Thanks @gillespi314!

What if I (IT admin) don't have the IdP or EULA configured? Do my end users still see the "Please enter your credentials..." screen?

Screenshot 2024-06-11 at 2 24 26 PM

For now, I think let's update step (4) in the copy for macOS >= 14 (from Figma here):

Screenshot 2024-06-11 at 3 40 31 PM

Also, I added this dev note to track the TODO for understanding how/when that "Please enter your credentials..." screen above shows up.

@marko-lisica when you're back online, can you please take that research?

@lukeheath lukeheath removed :incoming New issue in triage process. P2 Prioritize as urgent labels Jun 11, 2024
@lukeheath lukeheath added ~critical bug This is a critical bug and may require a patch release. P1 Prioritize as critical labels Jun 11, 2024
@marko-lisica
Copy link
Member

What if I (IT admin) don't have the IdP or EULA configured? Do my end users still see the "Please enter your credentials..." screen?

@noahtalerman I couldn't find exactly why this appears, but I think it's one of the ways to authenticate with your organization's account. In our case I believe web view with IdP login will appear. After login it will start downloading enrollment profile.

@nonpunctual
Copy link
Contributor

nonpunctual commented Jun 12, 2024

@noahtalerman @marko-lisica unless this is something in new in Sonoma (I was enrolling lots of Sonoma computers not that long ago) I don't think we should be seeing a prompt for credentials there. I am wondering if somehow we are using a user enrollment workflow instead of a fully automated workflow for enrollment? https://it-training.apple.com/tutorials/deployment/dm130

@noahtalerman
Copy link
Member

noahtalerman commented Jun 12, 2024

Hey @nonpunctual just to clarify, we (Fleet) haven't seen that "Enter your credentials.." prompt yet. We found it in Kevin Cox's article here.

We're trying to learn when/how it shows up.

it's one of the ways to authenticate with your organization's account

It could also be their local account? "your credentials" isn't giving us a lot of leads..

I did a quick search through the DEP profile developer docs (where we configure the configuration_web_url if the IT admin wants to require end user auth w/ their IdP) and I don't see anything else related to authentication/credentials.

Let me reach out to Kevin in the Mac Admins Slack.

@PezHub
Copy link
Contributor

PezHub commented Jun 17, 2024

QA Notes:
Confirmed I'm seeing the banner in Fleetd and the notifcation in system settings now during the migration flow
Screenshot 2024-06-17 at 1 20 41 PM
Device enrolled in Fleet (from another MDM) successfully.

I also ran thru clicking not now and Enroll to ensure those work as well.
Screenshot 2024-06-17 at 1 19 19 PM

Things are looking good
Screenshot 2024-06-17 at 12 14 44 PM

We did discover a recent change requires a fix before moving this to ready for release so I will track #19812 then retest to ensure all is good

@georgekarrv georgekarrv added this to the 4.52.0 milestone Jun 18, 2024
@georgekarrv
Copy link
Member

@zayhanlon This may take another day or two to fix fully and test. Would you like to hold the release for this or push this fix into next weeks release?

@zayhanlon
Copy link
Contributor

for audit trail purposes - discussed with alex m and we want to hold until thursday @georgekarrv
https://fleetdm.slack.com/archives/C062D0THVV1/p1718727279910679

roperzh pushed a commit that referenced this issue Jun 18, 2024
Follow up to address additional issues uncovered during QA of #19512
@PezHub
Copy link
Contributor

PezHub commented Jun 19, 2024

All blockers have been fixed and the migration workflow succeeded for both my MBair and Mac mini devices.
https://www.loom.com/share/37cdd0e31da14ebb936da4bce031c1da?sid=aeca33ae-e292-4fd4-83ef-18c1fe40e21e

georgekarrv pushed a commit that referenced this issue Jun 20, 2024
Follow up to address additional issues uncovered during QA of #19512
@fleet-release
Copy link
Contributor

Migration in silence,
Fleet lights the path to progress,
Mac finds its new home.

@georgekarrv georgekarrv added :demo and removed :demo labels Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working as documented ~critical bug This is a critical bug and may require a patch release. ~csa Issue was created by or deemed important by the Customer Solutions Architect. #g-mdm MDM product group P1 Prioritize as critical prospect-redwine prospect-velleda :release Ready to write code. Scheduled in a release. See "Making changes" in handbook. ~released bug This bug was found in a stable release.
Development

No branches or pull requests