-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ui): folder tab view #260
Conversation
fix(ui): Auth > OAuth 2 is not applied to requests (#259) fix: show folder icon
✅ Deploy Preview for chimerical-kitsune-a0bfa0 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for chimerical-kitsune-a0bfa0 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
So let's not have the folder view open on clicking the sidebar item. Let it open when clicking folder properties. We can't have both collapse / expanding ui action + opening folder properies in the same ui action. It feels very odd. I want to retain expanding and collapsing folder on click. Let's just open the folder panel instead of folder properties modal when clicking folder properties. |
|
In Postman, there are separate buttons for collapsing / expanding. How do you collapse / expand in Insomnia if click opens folder panel? Regardless of their design decisions, I don't want 2 ui actions on a single click. I specifically want to preserve click to collapse / expand. If you want this new behavior, you can make this a setting. Not the default behavior, so you can have the ux you like, while the default ux is preserved. Bruno actually behaves the same way. Where click expands / collapses, while right click -> Settings opens the folder view. |
This seems unnecessary. I don't know why they would keep both Folder Properties and Folder Panel. Seems very odd.
I'm open to exploring this ux. Can you see if you can implement this? |
Thanks for your inputs! Let me see how I could approach this. |
I thought about this and realized the reason they're keeping both Folder Properties and Folder Panel is because request also has the same properties context menu item. And I assume they're keeping it for consistency's sake. |
Does it sound like we need to separate the Folder Properties and Folder Panel? |
Yes. Let's remove auth and headers from folder properties. And remove folder name and parent folder inputs from folder panel. |
Sounds good! Updated! |
How does this UX sound? Single click to expand Or a gear/option icon at the end to open it |
Double click can't be relied on for a primary action. For people who use a touchscreen or a touchpad, it's not a good experience. Only people with a mouse can do this well. Plus the discoverability of this is also very low. As it doesn't seem like standard ui behavior. All primary actions should happen with a singular touch or click. Adding a gear when there's already a 3 dot context menu opening button beside the folder title is not good as it adds too many clickable actions in a very small area. Also visual clutter. Let's keep this as simple as possible. No exotic custom ui behaviors that are not easy to discover. In ui ux design we should choose behaviors that are already present in most applications and the user shouldn't feel like they have to learn a new thing to use the application. Every ui action should be obvious. |
@kobenguyent Merging this for now. Let's look into improving the click expand + tab open behavior later as it doesn't seem that pressing. |
Thanks @flawiddsouza |
resolves #235
@flawiddsouza Not sure if we need to remove the Folder Properties on context menu when this PR is approved.
Updated: