Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui): folder tab view #260

Merged
merged 8 commits into from
Sep 28, 2024
Merged

feat(ui): folder tab view #260

merged 8 commits into from
Sep 28, 2024

Conversation

kobenguyent
Copy link
Collaborator

@kobenguyent kobenguyent commented Sep 27, 2024

resolves #235

@flawiddsouza Not sure if we need to remove the Folder Properties on context menu when this PR is approved.

Updated:

  • clicking on folder item would open new tab to set auth and header
  • right clicking on properties to open the model to set name and path

Screenshot 2024-09-27 at 12 02 10

kobenguyent and others added 2 commits September 27, 2024 12:08
fix(ui): Auth > OAuth 2 is not applied to requests (#259)

fix: show folder icon
Copy link

netlify bot commented Sep 27, 2024

Deploy Preview for chimerical-kitsune-a0bfa0 ready!

Name Link
🔨 Latest commit 6e0b8ef
🔍 Latest deploy log https://app.netlify.com/sites/chimerical-kitsune-a0bfa0/deploys/66f684d2d15d77000829b641
😎 Deploy Preview https://deploy-preview-260--chimerical-kitsune-a0bfa0.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Sep 27, 2024

Deploy Preview for chimerical-kitsune-a0bfa0 ready!

Name Link
🔨 Latest commit 95633eb
🔍 Latest deploy log https://app.netlify.com/sites/chimerical-kitsune-a0bfa0/deploys/66f79484eda0b300088b1452
😎 Deploy Preview https://deploy-preview-260--chimerical-kitsune-a0bfa0.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@flawiddsouza
Copy link
Owner

So let's not have the folder view open on clicking the sidebar item. Let it open when clicking folder properties. We can't have both collapse / expanding ui action + opening folder properies in the same ui action. It feels very odd. I want to retain expanding and collapsing folder on click. Let's just open the folder panel instead of folder properties modal when clicking folder properties.

@kobenguyent
Copy link
Collaborator Author

kobenguyent commented Sep 27, 2024

Screenshot 2024-09-27 at 13 04 06

  • well, I checked with postman, and imho, clicking folder to open the folder panel would give better UX, as I don't need to right click, then another click on Properties.
  • insomnia, however, doesn't support tab yet, so I could not tell their approach. But their UX is the same, clicking folder leads your right away to folder panel

@flawiddsouza
Copy link
Owner

In Postman, there are separate buttons for collapsing / expanding.

How do you collapse / expand in Insomnia if click opens folder panel?

Regardless of their design decisions, I don't want 2 ui actions on a single click. I specifically want to preserve click to collapse / expand. If you want this new behavior, you can make this a setting. Not the default behavior, so you can have the ux you like, while the default ux is preserved.

Bruno actually behaves the same way. Where click expands / collapses, while right click -> Settings opens the folder view.

@kobenguyent
Copy link
Collaborator Author

Regarding the Insomnia:

  • Expanding / Collapsing when clicking on the folder icon
  • Clicking folder name will lead to folder panel
  • they do have folder properties and here is the UI
    Screenshot 2024-09-27 at 13 51 07

@flawiddsouza
Copy link
Owner

they do have folder properties and here is the UI

This seems unnecessary. I don't know why they would keep both Folder Properties and Folder Panel. Seems very odd.

Expanding / Collapsing when clicking on the folder icon
Clicking folder name will lead to folder panel

I'm open to exploring this ux. Can you see if you can implement this?

@kobenguyent
Copy link
Collaborator Author

they do have folder properties and here is the UI

This seems unnecessary. I don't know why they would keep both Folder Properties and Folder Panel. Seems very odd.

Expanding / Collapsing when clicking on the folder icon
Clicking folder name will lead to folder panel

I'm open to exploring this ux. Can you see if you can implement this?

Thanks for your inputs! Let me see how I could approach this.

@flawiddsouza
Copy link
Owner

This seems unnecessary. I don't know why they would keep both Folder Properties and Folder Panel. Seems very odd.

I thought about this and realized the reason they're keeping both Folder Properties and Folder Panel is because request also has the same properties context menu item. And I assume they're keeping it for consistency's sake.

@kobenguyent
Copy link
Collaborator Author

This seems unnecessary. I don't know why they would keep both Folder Properties and Folder Panel. Seems very odd.

I thought about this and realized the reason they're keeping both Folder Properties and Folder Panel is because request also has the same properties context menu item. And I assume they're keeping it for consistency's sake.

Does it sound like we need to separate the Folder Properties and Folder Panel?

@flawiddsouza
Copy link
Owner

Yes. Let's remove auth and headers from folder properties. And remove folder name and parent folder inputs from folder panel.

@kobenguyent
Copy link
Collaborator Author

Yes. Let's remove auth and headers from folder properties. And remove folder name and parent folder inputs from folder panel.

Sounds good! Updated!

@NeuronEnix
Copy link
Contributor

NeuronEnix commented Sep 28, 2024

How does this UX sound?

Single click to expand
Double click to open postman like folder property/panel

Or a gear/option icon at the end to open it

@flawiddsouza
Copy link
Owner

How does this UX sound?

Single click to expand
Double click to open postman like folder property/panel

Or a gear/option icon at the end to open it

Double click can't be relied on for a primary action. For people who use a touchscreen or a touchpad, it's not a good experience. Only people with a mouse can do this well. Plus the discoverability of this is also very low. As it doesn't seem like standard ui behavior. All primary actions should happen with a singular touch or click.

Adding a gear when there's already a 3 dot context menu opening button beside the folder title is not good as it adds too many clickable actions in a very small area. Also visual clutter. Let's keep this as simple as possible. No exotic custom ui behaviors that are not easy to discover.

In ui ux design we should choose behaviors that are already present in most applications and the user shouldn't feel like they have to learn a new thing to use the application. Every ui action should be obvious.

@flawiddsouza flawiddsouza merged commit b51a080 into main Sep 28, 2024
6 checks passed
@flawiddsouza flawiddsouza deleted the feat-folder-tab-view branch September 28, 2024 14:56
@flawiddsouza
Copy link
Owner

@kobenguyent Merging this for now. Let's look into improving the click expand + tab open behavior later as it doesn't seem that pressing.

@kobenguyent
Copy link
Collaborator Author

@kobenguyent Merging this for now. Let's look into improving the click expand + tab open behavior later as it doesn't seem that pressing.

Thanks @flawiddsouza

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Folder properties as view instead of a popup when clicking on the Folder
3 participants