Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flathub validations #64

Open
1 of 4 tasks
GeorgesStavracas opened this issue Nov 23, 2021 · 4 comments
Open
1 of 4 tasks

Flathub validations #64

GeorgesStavracas opened this issue Nov 23, 2021 · 4 comments
Labels
enhancement New feature or request flat-manager
Milestone

Comments

@GeorgesStavracas
Copy link
Member

GeorgesStavracas commented Nov 23, 2021

Seems like Flathub requires quite a few undocumented extra validation steps:

  • Run appstream-util validate from a relatively new appstream-glib (or via Flatpak from Flathub)
  • The app-info directory in the build dir needs both app-info XML and 128x128 icons
  • Screenshots need to be mirrored to https://dl.flathub.org/repo/screenshots (flatpak-builder: Add 'mirror-screenshots-url' input #63)
  • Screenshots need to be committed to screenshots/$architecture (e.g. $ ostree commit --repo=repo --canonical-permissions --branch=screenshots/x86_64 builddir/screenshots)

I'm leaning towards either adding a flathub-validations boolean option to the flat-manager action, or adding a validations string array option. Not sure which one is better.

@bilelmoussaoui
Copy link
Member

@GeorgesStavracas I would suggest adding a profile option to flat-manager that will automatically do everything needed for a flathub push. I don't think another profile will exist in the future and it will avoids us having a huge set of options to define and we avoid users not adding some validations to the list and publishing to the repo anyway

GeorgesStavracas added a commit to GeorgesStavracas/flatpak-github-actions that referenced this issue Nov 23, 2021
Add support for profiles, and add the 'flathub' profile.

Related: flatpak#64
@razzeee
Copy link

razzeee commented Nov 23, 2021

Screenshots need to be mirrored to dl.flathub.org/repo/screenshots (flatpak-builder: Add 'mirror-screenshots-url' input flathub-infra/backend#63)

Can logos be mirrored too? See flathub-infra/website#49

@bilelmoussaoui
Copy link
Member

Those apps do so for licensing reasons I believe.

@razzeee
Copy link

razzeee commented Nov 23, 2021

Not sure I get that, especially if you have a trademark, it shouldn't be problematic.

But we'll have problems with optimizing the pages, that show logos then, as we can't ensure, they're always there/loaded fast.

@bilelmoussaoui bilelmoussaoui modified the milestones: v5, v6 Dec 24, 2022
@bilelmoussaoui bilelmoussaoui added the enhancement New feature or request label Mar 18, 2023
@bilelmoussaoui bilelmoussaoui modified the milestones: v6, v7 Apr 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request flat-manager
Projects
None yet
Development

No branches or pull requests

3 participants