Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Summary shouldn't end with a fullstop #46

Closed
razzeee opened this issue Jun 28, 2023 · 2 comments
Closed

Summary shouldn't end with a fullstop #46

razzeee opened this issue Jun 28, 2023 · 2 comments

Comments

@razzeee
Copy link
Member

razzeee commented Jun 28, 2023

No description provided.

@tim77
Copy link
Collaborator

tim77 commented Jun 30, 2023

Hello @razzeee The same here: please submit and discuss this changes with upstream. Upstream should at least aware about downstream changes which they may not like.

I was guided only by the fact that I copied the original and have no right to change the description or something else. But your proposal is more only grammatical changes, so I think there will be no problems here.

Would you like to submit a PR here? Or I will update my PR as i can.

@razzeee
Copy link
Member Author

razzeee commented Jun 30, 2023

I think changing your pr makes the most sense

@razzeee razzeee closed this as not planned Won't fix, can't repro, duplicate, stale Jun 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@tim77 @razzeee and others