Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Discussion] General question about the wrapper repo #336

Closed
daiyam opened this issue May 7, 2024 · 4 comments · Fixed by #343
Closed

[Discussion] General question about the wrapper repo #336

daiyam opened this issue May 7, 2024 · 4 comments · Fixed by #343
Assignees

Comments

@daiyam
Copy link
Collaborator

daiyam commented May 7, 2024

Hi @noonsleeper,

I was wondering if it would be good to move your https://github.com/noonsleeper/ide-flatpak-wrapper repo under VSCodium org and to use the master branch instead of wayland-support.
Of course, you will maintain full access to the repo.

What do you think?

@noonsleeper
Copy link
Collaborator

Hey @daiyam,

TL;DR: to me is a good idea and if you like that way I can move the repo to codium org without hesitation =).

Now the large explanation xD

Originally it was created to merge PR on upstream branch zypak, but sometimes I can't wait then I use the fork until changes are merged, like in this particular case =).

Also, I was thinking to ask admins if I can be added as a maintainer on upstream.

@daiyam
Copy link
Collaborator Author

daiyam commented May 8, 2024

Now, I understand.
First, I will push your PR. If nothing happened, then you can move the fork.

@noonsleeper noonsleeper self-assigned this May 25, 2024
@noonsleeper
Copy link
Collaborator

Hi @daiyam, I made some changes on that PR 2 weeks ago, but I don't see any move

@daiyam
Copy link
Collaborator Author

daiyam commented Jun 7, 2024

Yep. Maybe, try to reformat the ifs to match the existing format (if []; then\n), push it and then ask for an update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants