Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

flathubbot going in circles with 0.0.68? #437

Closed
mvdan opened this issue Sep 17, 2024 · 3 comments · Fixed by #445
Closed

flathubbot going in circles with 0.0.68? #437

mvdan opened this issue Sep 17, 2024 · 3 comments · Fixed by #445

Comments

@mvdan
Copy link

mvdan commented Sep 17, 2024

It keeps doing dummy updates from 0.0.68 to 0.0.68, going back and forth between two URLs which presumably lead to the same release archive: https://github.com/flathub/com.discordapp.Discord/pulls?q=is%3Apr+0.0.68
@mvdan
Copy link
Author

mvdan commented Sep 17, 2024

cc @lionirdeadman

@guihkx
Copy link
Collaborator

guihkx commented Sep 17, 2024 •
edited
Loading

As a workaround, users annoyed by these frequent updates have the option to mask out all Discord updates with the following command:

flatpak mask com.discordapp.Discord

Once this issue is resolved, you can unmask Discord with:

flatpak mask --remove com.discordapp.Discord

See also: flathub-infra/flatpak-external-data-checker#438

I think the best option right now is to disable Flathub's update-checker. However, my impression is that this package is barely maintained (even though it's "official"), so future client updates might get delayed if we go that route.

guihkx added a commit to guihkx/com.discordapp.Discord that referenced this issue Sep 18, 2024
@guihkx
Disable Flathub's update checker and PR auto-merging
5192708 
At least until upstream addresses the following issue:

flathub-infra/flatpak-external-data-checker#438

This is to prevent the bot from opening (and merging) multiple pull
requests that point to the same version.

Closes flathub#437
@guihkx guihkx mentioned this issue Sep 18, 2024
Merged
@guihkx guihkx closed this as completed in 3ebfd7c Sep 18, 2024
@guihkx
Copy link
Collaborator

guihkx commented Sep 18, 2024 •
edited
Loading

Please note that even though this issue is closed, the underlying issue still exists.

For now though, all Discord updates will be pushed manually by me (but still checked automatically with nvchecker [1] [2], for faster updates).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Disable Flathub's update checker and PR auto-merging guihkx/com.discordapp.Discord
2 participants
@guihkx @mvdan